RESOLVED FIXED 143005
Add back previously broken assert from bug 141869
https://bugs.webkit.org/show_bug.cgi?id=143005
Summary Add back previously broken assert from bug 141869
Saam Barati
Reported 2015-03-24 08:44:57 PDT
Assert broke debug builds because it referenced an undeclared function parameter. But, if the parameter is declared, the assert is valid.
Attachments
patch (1.53 KB, patch)
2015-03-24 18:14 PDT, Saam Barati
msaboff: review+
commit-queue: commit-queue-
patch (1.53 KB, patch)
2015-03-27 09:34 PDT, Saam Barati
no flags
patch (1.54 KB, patch)
2015-03-27 12:51 PDT, Saam Barati
no flags
Saam Barati
Comment 1 2015-03-24 18:14:15 PDT
Michael Saboff
Comment 2 2015-03-24 18:15:29 PDT
Comment on attachment 249371 [details] patch Looks like it will build! r=me
WebKit Commit Bot
Comment 3 2015-03-24 19:02:07 PDT
Comment on attachment 249371 [details] patch Rejecting attachment 249371 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o runtime/ExceptionHelpers.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5717390864154624
Saam Barati
Comment 4 2015-03-24 19:22:49 PDT
(In reply to comment #3) > Comment on attachment 249371 [details] > patch > > Rejecting attachment 249371 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', > '--no-clean', '--no-update', '--build-style=release', '--port=mac']" > exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o > /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/ > JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o > > ** BUILD FAILED ** > > > The following build commands failed: > CompileC > /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/ > JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o > runtime/ExceptionHelpers.cpp normal x86_64 c++ > com.apple.compilers.llvm.clang.1_0.compiler > (1 failure) > > Full output: http://webkit-queues.appspot.com/results/5717390864154624 This seems weird. Builds fine on my machine. I'll update locally and see if it breaks on my clean build.
Saam Barati
Comment 5 2015-03-27 09:34:43 PDT
Created attachment 249573 [details] patch lets give this another go. If bots are okay with it, I will cq+
Saam Barati
Comment 6 2015-03-27 12:51:49 PDT
Created attachment 249599 [details] patch one more time should be using ASSERT_UNUSED
WebKit Commit Bot
Comment 7 2015-03-27 14:57:20 PDT
Comment on attachment 249599 [details] patch Clearing flags on attachment: 249599 Committed r182083: <http://trac.webkit.org/changeset/182083>
WebKit Commit Bot
Comment 8 2015-03-27 14:57:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.