Bug 143005 – Add back previously broken assert from bug 141869

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Assert broke debug builds because it
referenced an undeclared function parameter. 
But, if the parameter is declared, the assert
is valid.

[Saam Barati]

Created attachment 249371 [details]
patch

[Michael Saboff]

Comment on attachment 249371 [details]
patch

Looks like it will build!
r=me

[WebKit Commit Bot]

Comment on attachment 249371 [details]
patch

Rejecting attachment 249371 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o runtime/ExceptionHelpers.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5717390864154624

[Saam Barati]

(In reply to comment #3)
> Comment on attachment 249371 [details]
> patch
> 
> Rejecting attachment 249371 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build',
> '--no-clean', '--no-update', '--build-style=release', '--port=mac']"
> exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
> mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o
> /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/
> JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o
> 
> ** BUILD FAILED **
> 
> 
> The following build commands failed:
> 	CompileC
> /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/
> JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o
> runtime/ExceptionHelpers.cpp normal x86_64 c++
> com.apple.compilers.llvm.clang.1_0.compiler
> (1 failure)
> 
> Full output: http://webkit-queues.appspot.com/results/5717390864154624

This seems weird. Builds fine on my machine. I'll update locally
and see if it breaks on my clean build.

[Saam Barati]

Created attachment 249573 [details]
patch

lets give this another go.
If bots are okay with it, I will cq+

[Saam Barati]

Created attachment 249599 [details]
patch

one more time
should be using ASSERT_UNUSED

[WebKit Commit Bot]

Comment on attachment 249599 [details]
patch

Clearing flags on attachment: 249599

Committed r182083: <http://trac.webkit.org/changeset/182083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.