Bug 143003 - [GTK] Gardening 24th March
Summary: [GTK] Gardening 24th March
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-24 06:26 PDT by Marcos Chavarría Teijeiro (irc: chavaone)
Modified: 2015-03-25 04:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.18 KB, patch)
2015-03-24 06:34 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags Details | Formatted Diff | Diff
Patch (9.18 KB, patch)
2015-03-24 09:32 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags Details | Formatted Diff | Diff
Patch (9.04 KB, patch)
2015-03-25 01:29 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-24 06:26:03 PDT 
Unreviewed GTK+ Gardening test
Comment 1 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-24 06:34:49 PDT 
Created attachment 249325 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2015-03-24 06:42:28 PDT 
Comment on attachment 249325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249325&action=review

> LayoutTests/platform/gtk/TestExpectations:2369
> +#This tests are passing on GTK+ but they do not in the Apple ports

Please, put a space after the #

> LayoutTests/platform/gtk/TestExpectations:2372
> +  transitions/svg-text-shadow-transition.html [ Pass ]

Here there are two leading spaces that souldn't be.
Comment 3 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-24 09:32:05 PDT 
Created attachment 249329 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2015-03-24 09:47:33 PDT 
Comment on attachment 249329 [details]
Patch

thanks
Comment 5 WebKit Commit Bot 2015-03-24 09:49:22 PDT 
Comment on attachment 249329 [details]
Patch

Rejecting attachment 249329 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 249329, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-15c-expected.txt
patching file LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-15c-expected.txt
patching file LayoutTests/platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt
patching file LayoutTests/platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4836020088471552
Comment 6 Carlos Alberto Lopez Perez 2015-03-24 15:41:24 PDT 
Seems that the patch failed to apply on trunk:

Last 500 characters of output:
fset -1 lines).
1 out of 6 hunks FAILED -- saving rejects to file LayoutTests/platform/gtk/TestExpectations.rej

Can you rebase it and upload it again?
Comment 7 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-25 01:29:15 PDT 
Created attachment 249392 [details]
Patch
Comment 8 Marcos Chavarría Teijeiro (irc: chavaone) 2015-03-25 01:31:30 PDT 
(In reply to comment #6)
> Seems that the patch failed to apply on trunk:
> 
> Last 500 characters of output:
> fset -1 lines).
> 1 out of 6 hunks FAILED -- saving rejects to file
> LayoutTests/platform/gtk/TestExpectations.rej
> 
> Can you rebase it and upload it again?

done!
Comment 9 Carlos Alberto Lopez Perez 2015-03-25 04:03:34 PDT 
Comment on attachment 249392 [details]
Patch

let's retry it
Comment 10 WebKit Commit Bot 2015-03-25 04:54:04 PDT 
Comment on attachment 249392 [details]
Patch

Clearing flags on attachment: 249392

Committed r181953: <http://trac.webkit.org/changeset/181953>
Comment 11 WebKit Commit Bot 2015-03-25 04:54:08 PDT 
All reviewed patches have been landed.  Closing bug.