Bug 142976 - REGRESSION (r179820): accessibility/textarea-selected-text-range.html is flaky
Summary: REGRESSION (r179820): accessibility/textarea-selected-text-range.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-23 13:04 PDT by Alexey Proskuryakov
Modified: 2015-04-01 12:37 PDT (History)
10 users (show)

See Also:

Attachments
proposed fix (8.23 KB, patch)
2015-03-31 22:28 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-23 13:04:42 PDT 
accessibility/textarea-selected-text-range.html flakily fails on Mac bots (WK1 and WK2, Mavericks and Yosemite, debug and release).

@@ -1,4 +1,4 @@
-PASS textArea.selectedTextRange is '{4, 0}'
+FAIL textArea.selectedTextRange should be {4, 0}. Was {0, 0}.
 PASS textArea.selectedTextRange is '{8, 2}'
 PASS textArea.selectedTextRange is '{25, 0}'
 PASS successfullyParsed is true
Comment 1 Radar WebKit Bug Importer 2015-03-23 13:05:06 PDT 
<rdar://problem/20263270>
Comment 2 Alexey Proskuryakov 2015-03-23 13:06:57 PDT 
Marked as flaky in <http://trac.webkit.org/r181861>.
Comment 3 Alexey Proskuryakov 2015-03-31 22:25:10 PDT 
This is a regression from <http://trac.webkit.org/changeset/179820>. There is a race between a 1 ms delay timer and a dispatch_async - there is no ordering defined for these.
Comment 4 Alexey Proskuryakov 2015-03-31 22:28:06 PDT 
Created attachment 249894 [details]
proposed fix
Comment 5 chris fleizach 2015-03-31 23:14:47 PDT 
Comment on attachment 249894 [details]
proposed fix

shouldBecomeEquals. that's a great idea. thanks!
Comment 6 WebKit Commit Bot 2015-04-01 00:08:02 PDT 
Comment on attachment 249894 [details]
proposed fix

Clearing flags on attachment: 249894

Committed r182223: <http://trac.webkit.org/changeset/182223>
Comment 7 WebKit Commit Bot 2015-04-01 00:08:16 PDT 
All reviewed patches have been landed.  Closing bug.