Bug 142967 – [EFL][WK2] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model fails to pass

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

In test_ewk2_context, EWK2ContextTestMultipleProcesses.ewk_context_network_process_model is often failed. The failure reason is that webView1WebProcessID is same with webView2WebProcessID. Need to investigate.


    PlatformProcessIdentifier webView1WebProcessID = toImpl(EWKViewGetWKView(webView1))->page()->process().processIdentifier();
    PlatformProcessIdentifier webView2WebProcessID = toImpl(EWKViewGetWKView(webView2))->page()->process().processIdentifier();
    PlatformProcessIdentifier webView1NetworkProcessID = toImpl(EWKViewGetWKView(webView1))->page()->process().processPool().networkProcess()->processIdentifier();
    PlatformProcessIdentifier webView2NetworkProcessID = toImpl(EWKViewGetWKView(webView2))->page()->process().processPool().networkProcess()->processIdentifier();

    ASSERT_NE(webView1WebProcessID, webView2WebProcessID);

[Gyuyoung Kim]

This test result looks like flaky.

[Gyuyoung Kim]

I disable this test until fixing it in order to maintain EFL bot. Bug 143824 is filed to disable it.

[Gyuyoung Kim]

Created attachment 256687 [details]
Patch

[Gyuyoung Kim]

EWK2ContextTestMultipleProcesses.ewk_context_network_process_model test is flaky in EFL API test. When failure happens, process id is 0 as below,

../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:254: Failure
Expected: (webView1WebProcessID) != (webView2WebProcessID), actual: 0 vs 0
[  FAILED  ] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model (8 ms)
[----------] 2 tests from EWK2ContextTestMultipleProcesses (24 ms total)


It looks that 0 can be returned when page is not closed.

PlatformProcessIdentifier WebPageProxy::processIdentifier() const
{
    if (m_isClosed)
        return 0;

    return m_process->processIdentifier();
}

Unfortunately I don't know yet why a page is closed during the test. So I add a workaround condition which doesn't test it when process id is 0 for now.

[Gyuyoung Kim]

Created attachment 256690 [details]
Patch

[Gyuyoung Kim]

Ossy, ping ?

[Gyuyoung Kim]

Created attachment 256955 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 256955 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 256955 [details]
Patch

Clearing flags on attachment: 256955

Committed r187156: <http://trac.webkit.org/changeset/187156>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.