Bug 142965 - [CMake][EFL] Put failure API test excutables into failure directory
Summary: [CMake][EFL] Put failure API test excutables into failure directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 132813
  Show dependency treegraph
 
Reported: 2015-03-23 02:42 PDT by Gyuyoung Kim
Modified: 2015-03-23 04:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2015-03-23 02:43 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2015-03-23 03:09 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2015-03-23 03:12 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2015-03-23 03:23 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-23 02:42:10 PDT
Currently executables of failing WK2 API test are placed in WebKitBuild/Release/bin. I think it messes *bin* directory.
This patch moves the failing WK2 API tests to *WebKitBuid/Release|Debug/bin/TestWebKitAPI/WebKit2/failure* directory.
Comment 1 Gyuyoung Kim 2015-03-23 02:43:45 PDT
Created attachment 249229 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-23 03:06:50 PDT
Comment on attachment 249229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249229&action=review

LGTM, r=me.

> Tools/TestWebKitAPI/CMakeLists.txt:-220
> -    set_target_properties(${testBaseName} PROPERTIES

testBaseName was a typo here, wasn't it?
Comment 3 Gyuyoung Kim 2015-03-23 03:09:43 PDT
Created attachment 249230 [details]
Patch
Comment 4 Gyuyoung Kim 2015-03-23 03:11:01 PDT
(In reply to comment #2)
> Comment on attachment 249229 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249229&action=review
> 
> LGTM, r=me.

Additionally I remove unnecessary SHARED_CORE and comment for SeccompFilters test. Could you take a look again ?

> > Tools/TestWebKitAPI/CMakeLists.txt:-220
> > -    set_target_properties(${testBaseName} PROPERTIES
> 
> testBaseName was a typo here, wasn't it?

Yes, it was typo.
Comment 5 Gyuyoung Kim 2015-03-23 03:12:53 PDT
Created attachment 249231 [details]
Patch
Comment 6 Csaba Osztrogonác 2015-03-23 03:16:25 PDT
Comment on attachment 249231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249231&action=review

> Tools/ChangeLog:9
> +        Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. 

Does it mean that the seccomp test fails with and without SHARED_CORE on EFL?
Comment 7 Gyuyoung Kim 2015-03-23 03:19:05 PDT
(In reply to comment #6)
> Comment on attachment 249231 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249231&action=review
> 
> > Tools/ChangeLog:9
> > +        Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test. 
> 
> Does it mean that the seccomp test fails with and without SHARED_CORE on EFL?

yes, as far as I know, SHARED_CORE is not needed to run API test on EFL. It was needed to run layout test, however we need the option no longer since r172894. (Developer mode).
Comment 8 Gyuyoung Kim 2015-03-23 03:23:03 PDT
Created attachment 249232 [details]
Patch
Comment 9 Gyuyoung Kim 2015-03-23 03:25:09 PDT
Comment on attachment 249232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249232&action=review

> Tools/TestWebKitAPI/PlatformEfl.cmake:-132
> -# are not (and should not) be exposed by default. We

Symbol has been exposed since r172894. Thus SeccompFilters should not fail due to the SHARED_CORE.
Comment 10 Csaba Osztrogonác 2015-03-23 03:26:49 PDT
Comment on attachment 249232 [details]
Patch

Just a question: are there bug reports for the failing API tests and a meta bug to collect these bugs?
Comment 11 Gyuyoung Kim 2015-03-23 03:31:54 PDT
(In reply to comment #10)
> Comment on attachment 249232 [details]
> Patch
> 
> Just a question: are there bug reports for the failing API tests and a meta
> bug to collect these bugs?

Yes, bug 132813 is to handle failure API test for EFL port. We have to maintain it as well.

Bug 132813 - [EFL][WK2][Meta] Fix broken ewebkit2 API test cases
Comment 12 WebKit Commit Bot 2015-03-23 04:18:21 PDT
Comment on attachment 249232 [details]
Patch

Clearing flags on attachment: 249232

Committed r181853: <http://trac.webkit.org/changeset/181853>
Comment 13 WebKit Commit Bot 2015-03-23 04:18:26 PDT
All reviewed patches have been landed.  Closing bug.