Bug 142946 - tests/stress/*tdz* tests do 10x more iterations than necessary
Summary: tests/stress/*tdz* tests do 10x more iterations than necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-22 10:08 PDT by Filip Pizlo
Modified: 2015-03-22 11:26 PDT (History)
1 user (show)

See Also:


Attachments
the patch (5.68 KB, patch)
2015-03-22 10:09 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (6.28 KB, patch)
2015-03-22 11:21 PDT, Filip Pizlo
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-22 10:08:03 PDT
Stress tests should run for 10,000 iterations, where each iteration calls a function marked noInline, and that function contains the actual test content. Running for 100,000 iterations is 10x too many.
Comment 1 Filip Pizlo 2015-03-22 10:09:50 PDT
Created attachment 249199 [details]
the patch
Comment 2 Filip Pizlo 2015-03-22 11:21:18 PDT
Created attachment 249201 [details]
the patch

Added some commentary.
Comment 3 Filip Pizlo 2015-03-22 11:26:26 PDT
Landed in http://trac.webkit.org/changeset/181833