Bug 142931 - [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
Summary: [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 142938
  Show dependency tree / graph
 
Reported: 2015-03-20 21:08 PDT by Jer Noble
Modified: 2015-03-26 11:15 PDT (History)
0 users

See Also:

Attachments
Patch (16.09 KB, patch)
2015-03-20 22:13 PDT, Jer Noble 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-03-20 21:08:28 PDT 
[Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
Comment 1 Jer Noble 2015-03-20 22:13:43 PDT 
Created attachment 249162 [details]
Patch
Comment 2 Brent Fulgham 2015-03-25 15:05:35 PDT 
Comment on attachment 249162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249162&action=review

r=me.

> Tools/DumpRenderTree/TestRunner.h:56
> +    void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; }

Should this be passed as a const reference? Or does C++ now know how to magically do a move here?
Comment 3 Jer Noble 2015-03-26 10:19:22 PDT 
(In reply to comment #2)
> Comment on attachment 249162 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249162&action=review
> 
> r=me.
> 
> > Tools/DumpRenderTree/TestRunner.h:56
> > +    void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; }
> 
> Should this be passed as a const reference? Or does C++ now know how to
> magically do a move here?

I'll sprinkle on a little WTF::move. Thanks!
Comment 4 Jer Noble 2015-03-26 11:15:09 PDT 
Committed r182017: <http://trac.webkit.org/changeset/182017>