RESOLVED FIXED 142931
[Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers 
https://bugs.webkit.org/show_bug.cgi?id=142931
Summary [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connec...
Jer Noble
Reported 2015-03-20 21:08:28 PDT
[Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
Attachments
Patch (16.09 KB, patch)
2015-03-20 22:13 PDT, Jer Noble 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-03-20 22:13:43 PDT
Created attachment 249162 [details] Patch
Brent Fulgham
Comment 2 2015-03-25 15:05:35 PDT
Comment on attachment 249162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249162&action=review r=me. > Tools/DumpRenderTree/TestRunner.h:56 > + void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; } Should this be passed as a const reference? Or does C++ now know how to magically do a move here?
Jer Noble
Comment 3 2015-03-26 10:19:22 PDT
(In reply to comment #2) > Comment on attachment 249162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249162&action=review > > r=me. > > > Tools/DumpRenderTree/TestRunner.h:56 > > + void setAllowedHosts(std::set<std::string> hosts) { m_allowedHosts = hosts; } > > Should this be passed as a const reference? Or does C++ now know how to > magically do a move here? I'll sprinkle on a little WTF::move. Thanks!
Jer Noble
Comment 4 2015-03-26 11:15:09 PDT
Committed r182017: <http://trac.webkit.org/changeset/182017>
Note You need to log in before you can comment on or make changes to this bug.