Bug 142927 - Remove the prefix for CSS Transforms
Summary: Remove the prefix for CSS Transforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: WebExposed
Depends on: 142935
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-20 16:35 PDT by Dean Jackson
Modified: 2015-03-25 21:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (90.92 KB, patch)
2015-03-20 16:57 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (92.89 KB, patch)
2015-03-20 17:41 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (98.43 KB, patch)
2015-03-20 23:07 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (98.87 KB, patch)
2015-03-20 23:20 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (98.89 KB, patch)
2015-03-21 21:33 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-20 16:35:40 PDT 
It's 2015. The time has come to remove the -webkit prefix from the CSS transform properties:

- transform
- transform-origin
- transform-style
- perspective
- perspective-origin

For transform-style, we'll keep the older property around as well, so that if we change behaviour we can detect legacy content.
Comment 1 Dean Jackson 2015-03-20 16:35:55 PDT 
<rdar://problem/11568151>
Comment 2 Dean Jackson 2015-03-20 16:57:05 PDT 
Created attachment 249148 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-03-20 17:12:21 PDT 
Comment on attachment 249148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249148&action=review

> LayoutTests/transforms/2d/transform-2d-prefixed.html:2
> +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
> +   "http://www.w3.org/TR/html4/loose.dtd">

<!DOCTYPE html>

> LayoutTests/transforms/2d/transform-2d-prefixed.html:4
> +<html lang="en">

no lang

> LayoutTests/transforms/2d/transform-2d-prefixed.html:6
> +  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

remove
Comment 4 Dean Jackson 2015-03-20 17:41:25 PDT 
Created attachment 249153 [details]
Patch
Comment 5 Dean Jackson 2015-03-20 23:07:33 PDT 
Created attachment 249163 [details]
Patch
Comment 6 Dean Jackson 2015-03-20 23:20:00 PDT 
Created attachment 249164 [details]
Patch
Comment 7 Dean Jackson 2015-03-20 23:55:07 PDT 
Committed r181824: <http://trac.webkit.org/changeset/181824>
Comment 9 WebKit Commit Bot 2015-03-21 00:27:49 PDT 
Re-opened since this is blocked by bug 142935
Comment 10 Alexey Proskuryakov 2015-03-21 00:41:37 PDT 
Comment on attachment 249164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249164&action=review

> Source/WebCore/css/CSSPropertyNames.in:618
> +# Keeping -webkit-transform-style around is how we'll detect legacy content. At that point
> +# we'll have to add a custom builder and a new ETransformStyle3D type.

I suspect that it could be due to these comments - this file uses C++ style comments elsewhere.
Comment 11 Dean Jackson 2015-03-21 21:33:20 PDT 
Created attachment 249190 [details]
Patch
Comment 12 Dean Jackson 2015-03-21 21:56:36 PDT 
Committed r181832: <http://trac.webkit.org/changeset/181832>