Bug 142926 - FunctionBodyNode should known where its parameters started
Summary: FunctionBodyNode should known where its parameters started
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-20 15:52 PDT by Geoffrey Garen
Modified: 2015-03-20 16:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (26.53 KB, patch)
2015-03-20 15:56 PDT, Geoffrey Garen 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-20 15:52:15 PDT 
FunctionBodyNode should known where its parameters started
Comment 1 Geoffrey Garen 2015-03-20 15:56:10 PDT 
Created attachment 249140 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-20 15:58:41 PDT 
Attachment 249140 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Nodes.cpp:178:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/Nodes.cpp:179:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/Nodes.cpp:180:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2015-03-20 16:33:43 PDT 
Comment on attachment 249140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249140&action=review

> Source/JavaScriptCore/parser/Nodes.cpp:174
> +    ParserArena&, const JSTokenLocation& startLocation, 
> +    const JSTokenLocation& endLocation, unsigned startColumn, unsigned endColumn, 
> +    int functionKeywordStart, int functionNameStart, int parametersStart,
> +    bool isInStrictContext, ConstructorKind constructorKind)

These lines need to be indented further by 4 spaces (8 spaces total).
Comment 4 Geoffrey Garen 2015-03-20 16:38:26 PDT 
Committed r181818: <http://trac.webkit.org/changeset/181818>