Bug 142918 - Web Inspector: gaps between sections of the styles sidebar rules tab confusing, should say "Media: all"
Summary: Web Inspector: gaps between sections of the styles sidebar rules tab confusin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-20 12:59 PDT by Jonathan Wells
Modified: 2015-06-22 15:03 PDT (History)
8 users (show)

See Also:


Attachments
[SCREENSHOT] Styles sidebar rules tab (161.71 KB, image/png)
2015-03-20 12:59 PDT, Jonathan Wells
no flags Details
Patch (3.49 KB, patch)
2015-06-21 11:24 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (3.51 KB, patch)
2015-06-22 10:03 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2015-03-20 12:59:52 PDT
Created attachment 249132 [details]
[SCREENSHOT] Styles sidebar rules tab

There are gray gaps between sections in the styles sidebar rules tab when there are media queries in a document. apple.com is a good example to see this in action. Some sections will start with "Media: only screen", etc, for the corresponding query, but other sections will say nothing, Perhaps those should say "Media: all" or "All media."

Attached screenshot shows the issue.
Comment 1 Radar WebKit Bug Importer 2015-03-20 13:00:12 PDT
<rdar://problem/20243078>
Comment 2 Devin Rousso 2015-06-21 11:24:31 PDT
Created attachment 255330 [details]
Patch
Comment 3 Timothy Hatcher 2015-06-22 10:00:51 PDT
Comment on attachment 255330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255330&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Now properly adds padding to filtered labels.

Should wrap the comment to the next line.

> Source/WebInspectorUI/ChangeLog:12
> +        (WebInspector.RulesStyleDetailsPanel.prototype.refresh): If a section of CSS rules has no media or ineritance, add a label that says "Media: all" above the section.

Typo: inheritance?

Should wrap this long line too.
Comment 4 Devin Rousso 2015-06-22 10:03:56 PDT
Created attachment 255353 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-22 15:02:57 PDT
Comment on attachment 255353 [details]
Patch

Clearing flags on attachment: 255353

Committed r185845: <http://trac.webkit.org/changeset/185845>
Comment 6 WebKit Commit Bot 2015-06-22 15:03:00 PDT
All reviewed patches have been landed.  Closing bug.