Bug 142904 - [Content Filtering] Adopt NEFilterSource unblock handling
Summary: [Content Filtering] Adopt NEFilterSource unblock handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks: 128858
  Show dependency tree / graph
 
Reported: 2015-03-20 01:53 PDT by Andy Estes
Modified: 2015-03-20 02:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2015-03-20 02:03 PDT, Andy Estes 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-03-20 01:53:38 PDT 
[Content Filtering] Adopt NEFilterSource unblock handling
Comment 1 Andy Estes 2015-03-20 02:03:36 PDT 
Created attachment 249099 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-20 02:04:55 PDT 
Attachment 249099 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:169:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:170:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andy Estes 2015-03-20 02:05:43 PDT 
rdar://problem/19158925
Comment 4 Andreas Kling 2015-03-20 02:12:03 PDT 
Comment on attachment 249099 [details]
Patch

r=me
Comment 5 Andy Estes 2015-03-20 02:37:07 PDT 
Committed r181795: <http://trac.webkit.org/changeset/181795>