[Content Filtering] Add tests for unblock requests
Created attachment 249093 [details] Patch
Attachment 249093 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ContentFilter.cpp:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/loader/ContentFilter.cpp:148: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/testing/MockContentFilter.cpp:100: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:51: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:125: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 249093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249093&action=review r=me > Source/WebCore/testing/MockContentFilter.cpp:111 > + return "unblockRequestDenied()"; This would be slightly more efficient using ASCIILiteral: return ASCIILiteral("unblockRequestDenied()"); > Source/WebKit2/UIProcess/WebFrameProxy.cpp:245 > + if (unblocked && page) > + page->reload(false); 'page' cannot be null here, since the only caller of this function is a member function in WebPageProxy. This could just be an assertion outside the block.
Committed r181791: <http://trac.webkit.org/changeset/181791>