Bug 142889 - [Mac] Move MediaPlaybackTargetPicker
Summary: [Mac] Move MediaPlaybackTargetPicker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 18:31 PDT by Eric Carlson
Modified: 2015-03-19 20:53 PDT (History)
0 users

See Also:

Attachments
Proposed patch (66.75 KB, patch)
2015-03-19 18:39 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-03-19 18:31:37 PDT 
Move WebMediaPlaybackTargetPickerMacProxy.* to WebCore so the classes can be used by both WK1 and WK2.
Comment 1 Eric Carlson 2015-03-19 18:39:43 PDT 
Created attachment 249075 [details]
Proposed patch
Comment 2 Tim Horton 2015-03-19 18:49:14 PDT 
Comment on attachment 249075 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249075&action=review

> Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:31
> +#include <wtf/RefCounted.h>

why?

> Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.h:32
> +#include <wtf/RefPtr.h>

why?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:103
> +    m_deviceChangeTimer.stop();
> +    m_deviceChangeTimer.startOneShot(0);

are both of these necessary?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:112
> +        [m_devicePickerMenuController.get() addObserver:m_devicePickerMenuControllerDelegate.get() forKeyPath:externalOutputDeviceAvailableKeyName options:NSKeyValueObservingOptionNew context:nullptr];

no .get()s throughout here.
Comment 3 Eric Carlson 2015-03-19 20:53:28 PDT 
Committed r181777: http://trac.webkit.org/changeset/181777