Bug 142876 - [GTK] Search for the Wayland dependency when enabling Wayland target
Summary: [GTK] Search for the Wayland dependency when enabling Wayland target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-19 13:10 PDT by Zan Dobersek
Modified: 2015-03-20 02:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2015-03-19 13:12 PDT, Zan Dobersek 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-03-19 13:10:46 PDT 
[GTK] Search for the Wayland dependency when enabling Wayland target
Comment 1 Zan Dobersek 2015-03-19 13:12:35 PDT 
Created attachment 249054 [details]
Patch
Comment 2 Martin Robinson 2015-03-19 13:20:23 PDT 
Comment on attachment 249054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review

> ChangeLog:9
> +        requirement of either the GTK+ ord GDK pkg-config files, so we have to

Nit: ord -> or

> Source/cmake/OptionsGTK.cmake:82
> +if (ENABLE_WAYLAND_TARGET)
> +    find_package(Wayland REQUIRED)
> +endif ()
> +

Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well?
Comment 3 Zan Dobersek 2015-03-20 01:20:13 PDT 
Comment on attachment 249054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review

>> Source/cmake/OptionsGTK.cmake:82
>> +
> 
> Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well?

They're already listed in Source/WebCore/PlatformGTK.cmake.
Comment 4 Zan Dobersek 2015-03-20 02:24:19 PDT 
Committed r181793: <http://trac.webkit.org/changeset/181793>