WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142859
[GTK] Fix build break after
r181720
https://bugs.webkit.org/show_bug.cgi?id=142859
Summary
[GTK] Fix build break after r181720
Hunseop Jeong
Reported
2015-03-18 20:40:53 PDT
../../Source/WebCore/rendering/RenderImage.cpp: In member function ‘virtual void WebCore::RenderImage::styleDidChange(WebCore::StyleDifference, const WebCore::RenderStyle*)’: ../../Source/WebCore/rendering/RenderImage.cpp:225:57: error: expected ‘)’ before ‘;’ token repaintOrMarkForLayout(ImageSizeChangeForAltText; Fix typo.
Attachments
Patch
(1.49 KB, patch)
2015-03-18 20:44 PDT
,
Hunseop Jeong
ossy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hunseop Jeong
Comment 1
2015-03-18 20:44:16 PDT
Created
attachment 249012
[details]
Patch
Csaba Osztrogonác
Comment 2
2015-03-18 23:09:45 PDT
Comment on
attachment 249012
[details]
Patch It's not exactly related to GTK, but !ENABLE(CSS_IMAGE_RESOLUTION). But the fix is correct, r=me.
Csaba Osztrogonác
Comment 3
2015-03-18 23:11:10 PDT
already fixed by anyone else -
http://trac.webkit.org/changeset/181729
Csaba Osztrogonác
Comment 4
2015-03-18 23:12:31 PDT
Hunseop, please add a comment to the original bug too next time, because folks won't notice that somebody already fixed the build.
Csaba Osztrogonác
Comment 5
2015-03-18 23:18:20 PDT
(In reply to
comment #4
)
> Hunseop, please add a comment to the original bug too next time, > because folks won't notice that somebody already fixed the build.
And you can ask for review on #webkit immediately for important buildfix, feel free to ping the author and the reviewer of the original change or a random reviewer on #webkit, and then ask them to commit it too manually, it is much more faster than waiting for commit queue.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug