Bug 142859 - [GTK] Fix build break after r181720
Summary: [GTK] Fix build break after r181720
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks: 142805
  Show dependency tree / graph
 
Reported: 2015-03-18 20:40 PDT by Hunseop Jeong
Modified: 2015-03-18 23:18 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2015-03-18 20:44 PDT, Hunseop Jeong 		ossy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-03-18 20:40:53 PDT 
../../Source/WebCore/rendering/RenderImage.cpp: In member function ‘virtual void WebCore::RenderImage::styleDidChange(WebCore::StyleDifference, const WebCore::RenderStyle*)’:
../../Source/WebCore/rendering/RenderImage.cpp:225:57: error: expected ‘)’ before ‘;’ token
         repaintOrMarkForLayout(ImageSizeChangeForAltText;

Fix typo.
Comment 1 Hunseop Jeong 2015-03-18 20:44:16 PDT 
Created attachment 249012 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-18 23:09:45 PDT 
Comment on attachment 249012 [details]
Patch

It's not exactly related to GTK, but !ENABLE(CSS_IMAGE_RESOLUTION).
But the fix is correct, r=me.
Comment 3 Csaba Osztrogonác 2015-03-18 23:11:10 PDT 
already fixed by anyone else - http://trac.webkit.org/changeset/181729
Comment 4 Csaba Osztrogonác 2015-03-18 23:12:31 PDT 
Hunseop, please add a comment to the original bug too next time,
because folks won't notice that somebody already fixed the build.
Comment 5 Csaba Osztrogonác 2015-03-18 23:18:20 PDT 
(In reply to comment #4)
> Hunseop, please add a comment to the original bug too next time,
> because folks won't notice that somebody already fixed the build.

And you can ask for review on #webkit immediately for important buildfix,
feel free to ping the author and the reviewer of the original change
or a random reviewer on #webkit, and then ask them to commit it too
manually, it is much more faster than waiting for commit queue.