Bug 142851 - WeakGCMap pruning callback doesn't need to be a separate function.
Summary: WeakGCMap pruning callback doesn't need to be a separate function.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-18 17:35 PDT by Andreas Kling
Modified: 2015-03-18 20:35 PDT (History)
0 users

See Also:

Attachments
Patch (2.32 KB, patch)
2015-03-18 17:37 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-03-18 17:35:08 PDT 
Looking over WeakGCMap again, I realized that pruneStaleEntries() doesn't need to be a separate function, we can just fold it into the lambda we register with the heap.
Comment 1 Andreas Kling 2015-03-18 17:37:26 PDT 
Created attachment 248995 [details]
Patch
Comment 2 Andreas Kling 2015-03-18 20:35:50 PDT 
Comment on attachment 248995 [details]
Patch

This fails on Windows :(
c:\cygwin\home\buildbot\webkit\source\javascriptcore\runtime\WeakGCMapInlines.h(39): error C2899: typename cannot be used outside a template declaration