Bug 142849 - [GTK] Fix inspector userinterface related incremental build issue
Summary: [GTK] Fix inspector userinterface related incremental build issue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-18 17:16 PDT by Csaba Osztrogonác
Modified: 2015-03-25 01:34 PDT (History)
12 users (show)

See Also:


Attachments
Patch (1.21 KB, patch)
2015-03-18 17:18 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2015-03-18 23:37 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-03-18 17:16:31 PDT
Nowadays the GTK buildbot and EWS fails regularly with an inspector 
userinterface related incremental build issue. The problem is that
cmake should rerun to regenerate dependency when inspector userinterface
changes, but it doesn't run.

build error after r181704:
ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ScopeVariableTreeElement.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it

build error after r181517:
ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it


False positive incrementail build issues which needs manual fix by 
bot maintainers can be annoying and we should avoid them. I think we 
should simply rereun cmake always when this directory changes.
Comment 1 Csaba Osztrogonác 2015-03-18 17:18:00 PDT
Created attachment 248991 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-18 23:22:35 PDT
GTK bots and EWS are stucked again due to this bug:
ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it
Comment 3 Csaba Osztrogonác 2015-03-18 23:25:42 PDT
(note: r162545 used this idea for Options<EFL|GTK>.cmake and OptionsCommon.cmake)
Comment 4 Csaba Osztrogonác 2015-03-18 23:37:52 PDT
Created attachment 249020 [details]
Patch

with reverting the previous whitespace workaround
Comment 5 Carlos Garcia Campos 2015-03-19 00:35:42 PDT
Comment on attachment 249020 [details]
Patch

Let's try this way, thanks ossy!
Comment 6 WebKit Commit Bot 2015-03-19 01:19:57 PDT
Comment on attachment 249020 [details]
Patch

Clearing flags on attachment: 249020

Committed r181735: <http://trac.webkit.org/changeset/181735>
Comment 7 WebKit Commit Bot 2015-03-19 01:20:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Joonghun Park 2015-03-25 01:34:05 PDT
I think there is an insignificant variable name typo in this patch.
inspectorUserInterfaceDircetory -> inspectorUserInterfaceDirectory.