Bug 142848 – Test disk cache behavior when using back navigation cache policy

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

Add testing support and a test matrix.

[Antti Koivisto]

Created attachment 248990 [details]
patch

[Chris Dumez]

Comment on attachment 248990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248990&action=review

> Source/WebCore/testing/Internals.idl:49
> +    void setOverrideCachePolicy(unsigned short policy);

Would make the tests more readable if we used an IDL enum argument (or at least add static constants on Internals).

[Antti Koivisto]

Created attachment 248997 [details]
patch

[Chris Dumez]

Comment on attachment 248997 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248997&action=review

Still LGTM.

> LayoutTests/http/tests/cache/disk-cache-validation.html:-42
> -runTests(generateTests(testMatrix));

Not strictly related but OK.

[Chris Dumez]

Antti, it looks like http/tests/cache/disk-cache-validation.html and http/tests/cache/disk-cache-validation-back-navigation-policy.html may cause each other to be flaky. If I run each test on their own, they run fine.

However, if I run the whole http/ folder, http/tests/cache/disk-cache-validation.html is flaky with the following diff:
http://pastebin.com/1n2spiVB

[Chris Dumez]

Comment on attachment 248997 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248997&action=review

> Source/WebCore/testing/Internals.cpp:442
> +void Internals::setOverrideCachePolicy(const String& policy)

You probably want to clear the override cache policy from Internals::resetToConsistentState() to avoid flakiness.

[Antti Koivisto]

> You probably want to clear the override cache policy from
> Internals::resetToConsistentState() to avoid flakiness.

The field is in the FrameLoader which is per-document and doesn't affect any other tests. There shouldn't be need for this.

[Chris Dumez]

(In reply to comment #7)
> > You probably want to clear the override cache policy from
> > Internals::resetToConsistentState() to avoid flakiness.
> 
> The field is in the FrameLoader which is per-document and doesn't affect any
> other tests. There shouldn't be need for this.

It seems to fix the flakiness for me locally though.

[Antti Koivisto]

https://trac.webkit.org/r181728