RESOLVED FIXED 142847
Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause 
https://bugs.webkit.org/show_bug.cgi?id=142847
Summary Web Inspector: Debugger sidebar header should say "Scripts" instead of "Break...
Jonathan Wells
Reported 2015-03-18 16:54:27 PDT
When the debugger is paused, only then would the section with scripts and breakpoints need a header, which should just say "Scripts" at this point since scripts without breakpoints show as well, and because other information aside from just breakpoints is planned for the future.
Attachments
[PATCH] Unpaused debugger hides header, etc (5.58 KB, patch)
2015-03-18 18:03 PDT, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
[SCREENSHOT] 1. default sidebar view (76.06 KB, image/png)
2015-03-18 18:19 PDT, Jonathan Wells 		no flags
Details
[SCREENSHOT] 2. paused view (91.71 KB, image/png)
2015-03-18 18:19 PDT, Jonathan Wells 		no flags
Details
[SCREENSHOT] 3. paused view with collapsed script content (40.96 KB, image/png)
2015-03-18 18:20 PDT, Jonathan Wells 		no flags
Details
[SCREENSHOT] 4. resumed with collapsing being ignored (71.10 KB, image/png)
2015-03-18 18:20 PDT, Jonathan Wells 		no flags
Details
show only enabled Breakpoints (98.42 KB, image/png)
2015-03-19 01:14 PDT, Tobias Reiss 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jonathan Wells
Comment 1 2015-03-18 18:03:19 PDT
Created attachment 248999 [details] [PATCH] Unpaused debugger hides header, etc
Jonathan Wells
Comment 2 2015-03-18 18:19:20 PDT
Created attachment 249000 [details] [SCREENSHOT] 1. default sidebar view
Jonathan Wells
Comment 3 2015-03-18 18:19:43 PDT
Created attachment 249001 [details] [SCREENSHOT] 2. paused view
Jonathan Wells
Comment 4 2015-03-18 18:20:05 PDT
Created attachment 249002 [details] [SCREENSHOT] 3. paused view with collapsed script content
Jonathan Wells
Comment 5 2015-03-18 18:20:31 PDT
Created attachment 249004 [details] [SCREENSHOT] 4. resumed with collapsing being ignored
Tobias Reiss
Comment 6 2015-03-19 01:14:48 PDT
Created attachment 249024 [details] show only enabled Breakpoints Re: Screenshot 1-4 I like the "Scripts" header and I would even rename the placeholder in the search bar from "Filter Breakpoint list" to "Filter Scripts list" because it looks like you're not just filtering files that contain Breakpoints. What I'm missing is a quick way of removing all Breakpoints and a list of Breakpoints. But I'm not sure how strong I actually miss that feature. In case you want to spend more time on that I would propose adding a checkbox "Only show enabled Breakpoints" or a Button á la Xcode next to the search bar (See Screenshot).
Timothy Hatcher
Comment 7 2015-03-19 16:04:41 PDT
We could maybe the filter button a tri-state. All scripts with breakpoints, all scripts with enabled breakpoints, off (all scripts).
Timothy Hatcher
Comment 8 2015-03-19 16:06:22 PDT
Comment on attachment 248999 [details] [PATCH] Unpaused debugger hides header, etc You will want to update the filter placeholder. See line 111.
WebKit Commit Bot
Comment 9 2015-03-19 16:52:51 PDT
Comment on attachment 248999 [details] [PATCH] Unpaused debugger hides header, etc Clearing flags on attachment: 248999 Committed r181768: <http://trac.webkit.org/changeset/181768>
WebKit Commit Bot
Comment 10 2015-03-19 16:52:54 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Wells
Comment 11 2015-03-23 15:23:50 PDT
<rdar://problem/20266212>
Note You need to log in before you can comment on or make changes to this bug.