Bug 142816 - Call CTFontSetRenderingParameters before rendering text
Summary: Call CTFontSetRenderingParameters before rendering text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-18 00:39 PDT by Myles C. Maxfield
Modified: 2015-03-18 11:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.49 KB, patch)
2015-03-18 00:40 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-03-18 00:39:15 PDT
Call CTFontSetRenderingParameters before rendering text
Comment 1 Myles C. Maxfield 2015-03-18 00:40:48 PDT
Created attachment 248920 [details]
Patch
Comment 2 Myles C. Maxfield 2015-03-18 00:42:08 PDT
<rdar://problem/19446938>
Comment 3 Darin Adler 2015-03-18 08:28:10 PDT
Comment on attachment 248920 [details]
Patch

While this be efficient enough if we are calling it every time we call the show glyphs function? Is there a more optimal way to do this, perhaps only when the font changes?
Comment 4 Myles C. Maxfield 2015-03-18 10:25:54 PDT
(In reply to comment #3)
> Comment on attachment 248920 [details]
> Patch
> 
> While this be efficient enough if we are calling it every time we call the
> show glyphs function?

Currently, yes. If this ceases to be the case, I'll add a cache.
Comment 5 WebKit Commit Bot 2015-03-18 11:13:16 PDT
Comment on attachment 248920 [details]
Patch

Clearing flags on attachment: 248920

Committed r181703: <http://trac.webkit.org/changeset/181703>
Comment 6 WebKit Commit Bot 2015-03-18 11:13:20 PDT
All reviewed patches have been landed.  Closing bug.