Bug 142811 - Skip trying to paint overlay scrollbars when there are none or they are clipped out
Summary: Skip trying to paint overlay scrollbars when there are none or they are clipp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-17 22:44 PDT by Simon Fraser (smfr)
Modified: 2015-03-18 09:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2015-03-17 22:45 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-03-17 22:44:12 PDT
Skip trying to paint overlay scrollbars when there are none or they are clipped out
Comment 1 Simon Fraser (smfr) 2015-03-17 22:45:57 PDT
Created attachment 248912 [details]
Patch
Comment 2 Darin Adler 2015-03-18 08:34:37 PDT
Comment on attachment 248912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248912&action=review

> Source/WebCore/ChangeLog:14
> +        and don't both setting up an empty clip just to paint nothing.

both -> bother

> Source/WebCore/rendering/RenderLayer.cpp:4784
>      for (size_t i = 0; i < layerFragments.size(); ++i) {
>          const LayerFragment& fragment = layerFragments.at(i);

Should use modern for loop.
Comment 3 Simon Fraser (smfr) 2015-03-18 09:23:38 PDT
http://trac.webkit.org/changeset/181695