Bug 142809 - Simple line layout: Use Vector<>::const_iterator instead of custom FlowContents::Iterator.
Summary: Simple line layout: Use Vector<>::const_iterator instead of custom FlowConten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on: 142812
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-17 19:40 PDT by zalan
Modified: 2015-03-18 09:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.04 KB, patch)
2015-03-17 19:43 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.43 KB, patch)
2015-03-17 19:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.52 KB, patch)
2015-03-17 20:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-03-17 19:40:35 PDT 
FlowContents::Iterator iterates on a vector<>
Comment 1 zalan 2015-03-17 19:43:31 PDT 
Created attachment 248903 [details]
Patch
Comment 2 zalan 2015-03-17 19:47:26 PDT 
Created attachment 248904 [details]
Patch
Comment 3 WebKit Commit Bot 2015-03-17 20:45:55 PDT 
Comment on attachment 248904 [details]
Patch

Rejecting attachment 248904 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 248904, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
eded at 1 with fuzz 3.
patching file Source/WebCore/rendering/SimpleLineLayoutFlowContents.h
Hunk #1 succeeded at 46 with fuzz 2.
Hunk #2 FAILED at 58.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/SimpleLineLayoutFlowContents.h.rej
patching file Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5058877351526400
Comment 4 zalan 2015-03-17 20:50:30 PDT 
Created attachment 248905 [details]
Patch
Comment 5 WebKit Commit Bot 2015-03-17 21:01:17 PDT 
Comment on attachment 248905 [details]
Patch

Clearing flags on attachment: 248905

Committed r181683: <http://trac.webkit.org/changeset/181683>
Comment 6 WebKit Commit Bot 2015-03-17 21:01:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2015-03-17 23:06:03 PDT 
Re-opened since this is blocked by bug 142812
Comment 8 Alexey Proskuryakov 2015-03-17 23:08:27 PDT 
This patch depends on <http://trac.webkit.org/changeset/181667>, so it had to be reverted too. I am not aware of any problems with it per se.
Comment 9 zalan 2015-03-18 09:52:14 PDT 
Committed r181698: <http://trac.webkit.org/changeset/181698>