Bug 142807 – Make it possible to compute a region for elements on the page that have wheel event handlers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Make it possible to compute a region for elements on the page that have wheel event handlers

[Simon Fraser (smfr)]

Created attachment 248894 [details]
Patch

[Build Bot]

Comment on attachment 248894 [details]
Patch

Attachment 248894 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4871917962002432

New failing tests:
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html

[Build Bot]

Created attachment 248902 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Simon Fraser (smfr)]

Created attachment 248963 [details]
Patch

[Build Bot]

Comment on attachment 248963 [details]
Patch

Attachment 248963 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4904563471548416

New failing tests:
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll.html

[Build Bot]

Created attachment 248967 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Dave Hyatt]

Comment on attachment 248963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248963&action=review

r=me

> Source/WebCore/dom/Document.cpp:6118
> +        return renderView->documentRect();

Note that documentRect() does apply a transform. I don't know if you really wanted 

unscaledDocumentRect()

here or not. I'm not sure.

> Source/WebCore/dom/Element.cpp:957
> +LayoutRect Element::eventBounds(bool& boundsIncludeAllDescendantElements, bool& includesFixedPositionElements)

Should probably have absolute in the name.

> Source/WebCore/dom/Element.cpp:1013
> +LayoutRect Element::eventBoundsOfElementAndDescendants(bool& includesFixedPositionElements)

Should probably have absolute in the name.

[Jon Lee]

rdar://problem/16049624

[Simon Fraser (smfr)]

https://trac.webkit.org/r182215

[Alexey Proskuryakov]

This broke Windows build: 

WebCore.lib(InspectorAllInOne.obj) : error LNK2019: unresolved external symbol "public: class WebCore::FloatPoint __thiscall WebCore::RenderObject::localToAbsolute(class WebCore::FloatPoint const &,unsigned int)const " (?localToAbsolute@RenderObject@WebCore@@QBE?AVFloatPoint@2@ABV32@I@Z) referenced in function "class WebCore::FloatPoint __cdecl WebCore::localPointToRoot(class WebCore::RenderObject *,class WebCore::FrameView const *,class WebCore::FrameView const *,class WebCore::FloatPoint const &)" (?localPointToRoot@WebCore@@YA?AVFloatPoint@1@PAVRenderObject@1@PBVFrameView@1@1ABV21@@Z) [C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj]

WebCore.lib(InspectorAllInOne.obj) : error LNK2019: unresolved external symbol "public: class WebCore::IntRect __thiscall WebCore::RenderObject::absoluteBoundingBoxRect(bool)const " (?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z) referenced in function "private: class WTF::Ref<class Inspector::Protocol::LayerTree::Layer> __thiscall WebCore::InspectorLayerTreeAgent::buildObjectForLayer(class WTF::String &,class WebCore::RenderLayer *)" (?buildObjectForLayer@InspectorLayerTreeAgent@WebCore@@AAE?AV?$Ref@VLayer@LayerTree@Protocol@Inspector@@@WTF@@AAVString@4@PAVRenderLayer@2@@Z) [C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj]

[Alexey Proskuryakov]

I don't see anything wrong with the code, will try a clean build.

[Brent Fulgham]

*** Bug 124139 has been marked as a duplicate of this bug. ***