Bug 142806 - Web Inspector: Scrolling "jumps" in debugger sidebar
Summary: Web Inspector: Scrolling "jumps" in debugger sidebar
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 157657 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-17 17:45 PDT by Nikita Vasilyev
Modified: 2016-12-13 15:39 PST (History)
5 users (show)

See Also:

Attachments
Animated GIF of the problem (2.32 MB, image/gif)
2015-03-17 17:45 PDT, Nikita Vasilyev 		no flags Details
[Proposed] Patch (2.53 KB, patch)
2015-07-30 16:57 PDT, Devin Rousso 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-03-17 17:45:13 PDT 
Created attachment 248892 [details]
Animated GIF of the problem

Steps:

0. Open http://codemirror.net/demo/tern.html
1. Open Inspector
2. Set breakpoint on tern.js, line 206
3. Focus on the code editor on the demo page, and press Ctrl + Enter to trigger autocomplete.
Comment 1 Joseph Pecoraro 2015-03-17 18:28:26 PDT 
This is actually much easier to reproduce with the Scopes sidebar, since the Local Scope and Global Scope will be so large it has to scroll. Seemingly whenever we focus inside a section it scrolls to that detail-section.
Comment 2 Joseph Pecoraro 2015-03-17 18:29:51 PDT 
WebInspector.DetailsSection._headerElementClicked has a scrollIntoViewIfNeeded(false). I wonder if that is somehow getting run?
Comment 3 Joseph Pecoraro 2015-03-17 18:34:26 PDT 
(In reply to comment #2)
> WebInspector.DetailsSection._headerElementClicked has a
> scrollIntoViewIfNeeded(false). I wonder if that is somehow getting run?

Doesn't look like that is the case.
Comment 4 Joseph Pecoraro 2015-03-17 18:36:17 PDT 
Commenting out the focus() call inside `TreeElement.prototype.select` makes this stop. Maybe this was a focus() regression in WebCore?
Comment 5 Joseph Pecoraro 2015-03-17 18:38:13 PDT 
This is not a regression, it happens in older versions of Safari (lots of breakpoints and call stack). I think we should just be careful when we call focus().
Comment 6 Nikita Vasilyev 2015-06-27 20:54:48 PDT 
Despite the redesign, this is still happening.
Comment 7 Radar WebKit Bug Importer 2015-06-27 20:55:09 PDT 
<rdar://problem/21581884>
Comment 8 Devin Rousso 2015-07-30 16:57:40 PDT 
Created attachment 257879 [details]
[Proposed] Patch

I am not entirely sure why the focus call was necessary in LogContentView, but removing that call has stopped this from happening for me.  With that having been said, I have no way of reproducing this issue, but I've been testing with it for a few days and haven't seen this issue at all.
Comment 9 Nikita Vasilyev 2015-07-30 20:50:33 PDT 
Comment on attachment 257879 [details]
[Proposed] Patch

This patch didn't fix the bug for me. It modifies LogContentView.js, which is responsible for the console and seems to be unrelated to the debugger sidebar.
Comment 10 Nikita Vasilyev 2015-07-30 20:52:57 PDT 
(In reply to comment #8)
> With that having been said, I have no way of reproducing this issue, but I've been
> testing with it for a few days and haven't seen this issue at all.

Were you able to reproduce this issue at all? I just reproduced it on WebKit ToT.
Comment 11 Devin Rousso 2015-07-30 21:16:50 PDT 
Comment on attachment 257879 [details]
[Proposed] Patch

Oh Crap!  I completely missed the fact that this was in the Debugger tab.  I thought this was a bug for the jumping in the Console.  I'll make a new bug for that right now .  Sorry!
Comment 12 Matt Baker 2016-08-04 18:00:31 PDT 
*** Bug 157657 has been marked as a duplicate of this bug. ***
Comment 13 Nikita Vasilyev 2016-09-10 13:01:48 PDT 
Still reproducible.