WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142798
Refactor execution time limit tests out of testapi.c
https://bugs.webkit.org/show_bug.cgi?id=142798
Summary
Refactor execution time limit tests out of testapi.c
Mark Lam
Reported
2015-03-17 15:45:53 PDT
These tests were sometimes failing to time out on C loop builds. Let's refactor them out of the big monolith that is testapi.c so that we can reason more easily about them and make adjustments if needed.
Attachments
the patch.
(33.00 KB, patch)
2015-03-17 15:50 PDT
,
Mark Lam
msaboff
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2015-03-17 15:50:31 PDT
Created
attachment 248878
[details]
the patch.
Michael Saboff
Comment 2
2015-03-17 16:03:43 PDT
Comment on
attachment 248878
[details]
the patch. rs=me
Mark Lam
Comment 3
2015-03-17 16:07:49 PDT
Thanks. Landed in
r181670
: <
http://trac.webkit.org/r181670
>.
David Kilzer (:ddkilzer)
Comment 4
2015-03-21 10:25:50 PDT
Should the new file be added to JavaScriptCore.vcproj for Windows as well?
Brent Fulgham
Comment 5
2015-03-21 10:40:52 PDT
(In reply to
comment #4
)
> Should the new file be added to JavaScriptCore.vcproj for Windows as well?
Id ally there should be a Windows implementation of this, but as it stands these are Darwin-only so there's not much point in touching the VS project ere.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug