Bug 142795 - Function bodies should always include braces
Summary: Function bodies should always include braces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-17 15:03 PDT by Geoffrey Garen
Modified: 2015-03-17 17:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (26.19 KB, patch)
2015-03-17 16:22 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (20.87 KB, patch)
2015-03-17 16:30 PDT, Geoffrey Garen 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-17 15:03:54 PDT 
Function bodies should always include braces
Comment 1 Geoffrey Garen 2015-03-17 16:22:14 PDT 
Created attachment 248883 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-17 16:30:57 PDT 
Created attachment 248884 [details]
Patch
Comment 3 Michael Saboff 2015-03-17 16:57:22 PDT 
Comment on attachment 248884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review

r=me

> Source/JavaScriptCore/ChangeLog:24
> +        * generate-js-builtins: Ditto.

Ditto what?  Looks like you changed from using linkGlobalCode() to link().
Comment 4 Mark Lam 2015-03-17 17:05:22 PDT 
Comment on attachment 248884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248884&action=review

r=me too with comment typo fix.

> Source/JavaScriptCore/ChangeLog:41
> +        leading space because that's what this functinon's comment says is required

/functinon/function/
Comment 5 Geoffrey Garen 2015-03-17 17:07:57 PDT 
Committed r181673: <http://trac.webkit.org/changeset/181673>