Bug 142794 - check-webkit-style should allow "bool a : 1"
Summary: check-webkit-style should allow "bool a : 1"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-17 15:01 PDT by Dean Jackson
Modified: 2015-03-17 15:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2015-03-17 15:07 PDT, Dean Jackson 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-17 15:01:47 PDT 
check-webkit-style should allow "bool a : 1"
Comment 1 Dean Jackson 2015-03-17 15:03:20 PDT 
We should allow this type of bitfield in the style checker:

bool m_var : 1;

At the moment we warn, suggesting we should use unsigned. But we're actually using bool in a lot of places because Visual Studio 8 was the last compiler that wasn't happy, and we're long past that.
Comment 2 Dean Jackson 2015-03-17 15:07:38 PDT 
Created attachment 248872 [details]
Patch
Comment 3 Brent Fulgham 2015-03-17 15:14:47 PDT 
Comment on attachment 248872 [details]
Patch

r=me
Comment 4 Dean Jackson 2015-03-17 15:58:39 PDT 
Committed r181669: <http://trac.webkit.org/changeset/181669>