RESOLVED FIXED142794
check-webkit-style should allow "bool a : 1" 
https://bugs.webkit.org/show_bug.cgi?id=142794
Summary check-webkit-style should allow "bool a : 1"
Dean Jackson
Reported 2015-03-17 15:01:47 PDT
check-webkit-style should allow "bool a : 1"
Attachments
Patch (3.11 KB, patch)
2015-03-17 15:07 PDT, Dean Jackson 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-03-17 15:03:20 PDT
We should allow this type of bitfield in the style checker: bool m_var : 1; At the moment we warn, suggesting we should use unsigned. But we're actually using bool in a lot of places because Visual Studio 8 was the last compiler that wasn't happy, and we're long past that.
Dean Jackson
Comment 2 2015-03-17 15:07:38 PDT
Created attachment 248872 [details] Patch
Brent Fulgham
Comment 3 2015-03-17 15:14:47 PDT
Comment on attachment 248872 [details] Patch r=me
Dean Jackson
Comment 4 2015-03-17 15:58:39 PDT
Committed r181669: <http://trac.webkit.org/changeset/181669>
Note You need to log in before you can comment on or make changes to this bug.