Bug 142788 – Built-in functions should know that they use strict mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Built-in functions should know that they use strict mode

[Geoffrey Garen]

Created attachment 248863 [details]
Patch

[Geoffrey Garen]

Created attachment 248866 [details]
Patch

[WebKit Commit Bot]

Attachment 248866 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Parser.cpp:210:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 248866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248866&action=review

> Source/JavaScriptCore/parser/ParserModes.h:34
> +enum JSParserStrictMode { JSParseNotStrictMode, JSParseStrictMode };

Can we use enum class instead?  It makes future find/replace much easier and prevents accidental casts to integral types.

[Geoffrey Garen]

> Can we use enum class instead?

OK.

[Geoffrey Garen]

Created attachment 248869 [details]
Patch

[WebKit Commit Bot]

Attachment 248869 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Parser.cpp:210:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 248866 [details]
Patch

r=me with Ryosuke's suggested fixes (and style issue resolved if valid, though it doesn't look like a valid complaint to me from the diff).

[Mark Lam]

Comment on attachment 248869 [details]
Patch

r=me

[Geoffrey Garen]

Committed r181664: <http://trac.webkit.org/changeset/181664>