Bug 142785 - Simple line layout: Change FlowContents::segmentForPosition() to segmentForRun().
Summary: Simple line layout: Change FlowContents::segmentForPosition() to segmentForRu...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on: 142812
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-17 10:13 PDT by zalan
Modified: 2015-03-17 23:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2015-03-17 11:07 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.43 KB, patch)
2015-03-17 15:22 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.32 KB, patch)
2015-03-17 19:01 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-03-17 10:13:04 PDT
This is in transition to support <br>. <br> and a render text can be on the same (start) position.
Comment 1 zalan 2015-03-17 11:07:49 PDT
Created attachment 248854 [details]
Patch
Comment 2 zalan 2015-03-17 15:22:59 PDT
Created attachment 248873 [details]
Patch
Comment 3 zalan 2015-03-17 19:01:35 PDT
Created attachment 248899 [details]
Patch
Comment 4 WebKit Commit Bot 2015-03-17 20:41:27 PDT
Comment on attachment 248899 [details]
Patch

Clearing flags on attachment: 248899

Committed r181682: <http://trac.webkit.org/changeset/181682>
Comment 5 WebKit Commit Bot 2015-03-17 20:41:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2015-03-17 23:06:00 PDT
Re-opened since this is blocked by bug 142812
Comment 7 Alexey Proskuryakov 2015-03-17 23:08:13 PDT
This patch depends on <http://trac.webkit.org/changeset/181667>, so it had to be reverted too. I am not aware of any problems with it per se.