Bug 142784 – [WinCairo] Video position is incorrect when located inside a frame.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

We need to take the enclosing frame's position into account, when finding the video position.

Created attachment 248850 [details]
Patch

[Brent Fulgham]

Comment on attachment 248850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248850&action=review

This looks good to me. Could you please use "positionInWIndow" instead of "posInWindow" when you land it?

> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207
> +    IntPoint posInWindow(m_lastPaintRect.location());

I think this should be called "positionInWIndow".

(In reply to comment #2)
> Comment on attachment 248850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248850&action=review
> 
> This looks good to me. Could you please use "positionInWIndow" instead of
> "posInWindow" when you land it?
> 
> > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207
> > +    IntPoint posInWindow(m_lastPaintRect.location());
> 
> I think this should be called "positionInWIndow".

Thanks :) Will do.

[Brent Fulgham]

Comment on attachment 248850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248850&action=review

>>> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207
>>> +    IntPoint posInWindow(m_lastPaintRect.location());
>> 
>> I think this should be called "positionInWIndow".
> 
> Thanks :) Will do.

Of course, I meant "positionInWindow", not "positionInWIndow" ;-)

(In reply to comment #4)
> Comment on attachment 248850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248850&action=review
> 
> >>> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207
> >>> +    IntPoint posInWindow(m_lastPaintRect.location());
> >> 
> >> I think this should be called "positionInWIndow".
> > 
> > Thanks :) Will do.
> 
> Of course, I meant "positionInWindow", not "positionInWIndow" ;-)

Exactly ;)

Committed r181665: <http://trac.webkit.org/changeset/181665>

[Csaba Osztrogonác]

(In reply to comment #6)
> Committed r181665: <http://trac.webkit.org/changeset/181665>

This WinCairo fix broke the WinCairo build, it is so funny. :))

..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(215): error C2664: 'WebCore::IntPoint WebCore::Widget::convertToContainingWindow(const WebCore::IntPoint &) const' : cannot convert argument 1 from 'WebCore::FloatPoint' to 'const WebCore::IntRect &' [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
          Reason: cannot convert from 'WebCore::FloatPoint' to 'const WebCore::IntRect'
          No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
c:\cygwin\home\webkitbot\win-cairo-release\build\source\webcore\html\htmlelement.cpp(492): warning C4701: potentially uninitialized local variable 'c' used [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]

(In reply to comment #7)
> (In reply to comment #6)
> > Committed r181665: <http://trac.webkit.org/changeset/181665>
> 
> This WinCairo fix broke the WinCairo build, it is so funny. :))
> 
> ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(215): error
> C2664: 'WebCore::IntPoint WebCore::Widget::convertToContainingWindow(const
> WebCore::IntPoint &) const' : cannot convert argument 1 from
> 'WebCore::FloatPoint' to 'const WebCore::IntRect &'
> [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.
> vcxproj\WebCore.vcxproj]
>           Reason: cannot convert from 'WebCore::FloatPoint' to 'const
> WebCore::IntRect'
>           No user-defined-conversion operator available that can perform
> this conversion, or the operator cannot be called
> c:\cygwin\home\webkitbot\win-cairo-
> release\build\source\webcore\html\htmlelement.cpp(492): warning C4701:
> potentially uninitialized local variable 'c' used
> [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.
> vcxproj\WebCore.vcxproj]

Sorry for this, committed fix in <http://trac.webkit.org/changeset/181694>