Bug 142780 - [GTK] Wrong transfer annotations used in GObject DOM bindings
Summary: [GTK] Wrong transfer annotations used in GObject DOM bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-03-17 03:30 PDT by Carlos Garcia Campos
Modified: 2015-03-17 05:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2015-03-17 03:33 PDT, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-03-17 03:30:01 PDT
We are using transfer none for all methods returning a GObject DOM Object. That's not true. Only objects derived by Node are automatically released by the DOM object cache and can be transfer none. All other objects are added to the cache only to avoid creating the same wrapper twice for the same core object, but caller should release the returned reference. See also bug #118788
Comment 1 Carlos Garcia Campos 2015-03-17 03:33:11 PDT
Created attachment 248841 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-03-17 05:22:47 PDT
Committed r181643: <http://trac.webkit.org/changeset/181643>