Bug 142777 - Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources
Summary: Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jonathan Wells
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-17 02:09 PDT by Jonathan Wells
Modified: 2015-03-19 14:45 PDT (History)
8 users (show)

See Also:


Attachments
[SCREENSHOT] before filter is applied. (38.49 KB, image/png)
2015-03-17 02:11 PDT, Jonathan Wells
no flags Details
[SCREENSHOT] After filter is applied. (22.39 KB, image/png)
2015-03-17 02:11 PDT, Jonathan Wells
no flags Details
[PATCH] fix. (1.66 KB, patch)
2015-03-18 22:21 PDT, Jonathan Wells
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2015-03-17 02:09:44 PDT
When typing text into the input field of the filter bar beneath the debugger sidebar (breakpoints), the files that remain do not show their breakpoints.

To reproduce:

1. Add a breakpoint to a script file in a loaded page in the Debugger view.
2. Type in the first letter of that file into the filter bar

The breakpoint isn't visible as it should be.

Screenshots attached.
Comment 1 Radar WebKit Bug Importer 2015-03-17 02:10:25 PDT
<rdar://problem/20186576>
Comment 2 Jonathan Wells 2015-03-17 02:11:03 PDT
Created attachment 248831 [details]
[SCREENSHOT] before filter is applied.
Comment 3 Jonathan Wells 2015-03-17 02:11:47 PDT
Created attachment 248832 [details]
[SCREENSHOT] After filter is applied.
Comment 4 Timothy Hatcher 2015-03-17 09:43:11 PDT
This should be easy to fix by adding filterableData to the BreakpointTreeElement that contains the URL of the resource. Like ResourceTreeElement has.
Comment 5 Jonathan Wells 2015-03-18 22:21:05 PDT
Created attachment 249016 [details]
[PATCH] fix.
Comment 6 Brian Burg 2015-03-19 13:37:45 PDT
Comment on attachment 249016 [details]
[PATCH] fix.

r=me
Comment 7 WebKit Commit Bot 2015-03-19 14:45:36 PDT
Comment on attachment 249016 [details]
[PATCH] fix.

Clearing flags on attachment: 249016

Committed r181759: <http://trac.webkit.org/changeset/181759>
Comment 8 WebKit Commit Bot 2015-03-19 14:45:40 PDT
All reviewed patches have been landed.  Closing bug.