Vary: Cookie tells the cache not to use the entry if the cookie has changed.
rdar://problem/19764945
Created attachment 248804 [details] patch
Comment on attachment 248804 [details] patch Attachment 248804 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5195992571838464 New failing tests: http/tests/cache/disk-cache-vary-cookie.html
Created attachment 248812 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 248804 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=248804&action=review > Source/WebKit2/ChangeLog:9 > + Fetch then explicitly when resolving Vary: Cookie. then -> them > Source/WebKit2/ChangeLog:13 > + reasonable cases though. Fetching cookies for every request might be too expensive for this rarely used feature. Would it be worth having an assert to catch cases where cookies change in between? i.e. fetch the cookies for every request in debug builds and compare to what we saved.
Created attachment 248823 [details] another
> Would it be worth having an assert to catch cases where cookies change in > between? i.e. fetch the cookies for every request in debug builds and > compare to what we saved. Not sure what we would do with that information though.
Comment on attachment 248823 [details] another Clearing flags on attachment: 248823 Committed r181651: <http://trac.webkit.org/changeset/181651>
All reviewed patches have been landed. Closing bug.