RESOLVED FIXED 142762
Generalize the Document code that maintains a set of nodes with event handlers 
https://bugs.webkit.org/show_bug.cgi?id=142762
Summary Generalize the Document code that maintains a set of nodes with event handlers
Simon Fraser (smfr)
Reported 2015-03-16 18:57:17 PDT
Generalize the Document code that maintains a set of nodes with event handlers
Attachments
Patch (6.28 KB, patch)
2015-03-16 19:05 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2015-03-16 19:40 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-03-16 19:05:21 PDT
Created attachment 248779 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-03-16 19:40:29 PDT
Created attachment 248783 [details] Patch
Darin Adler
Comment 3 2015-03-16 20:21:39 PDT
Comment on attachment 248783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248783&action=review > Source/WebCore/testing/Internals.cpp:1216 > - const TouchEventTargetSet* touchHandlers = document->touchEventTargets(); > + const EventTargetSet* touchHandlers = document->touchEventTargets(); I think auto is better for things like this. > Source/WebCore/testing/Internals.cpp:1222 > - for (TouchEventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter) > + for (EventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter) > count += iter->value; This should be a modern for loop: for (auto& handler : *touchHandlers) count += handler.value;
Simon Fraser (smfr)
Comment 4 2015-03-16 21:45:00 PDT
https://trac.webkit.org/r181615
Note You need to log in before you can comment on or make changes to this bug.