Bug 142762 - Generalize the Document code that maintains a set of nodes with event handlers
Summary: Generalize the Document code that maintains a set of nodes with event handlers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-16 18:57 PDT by Simon Fraser (smfr)
Modified: 2015-03-16 21:45 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.28 KB, patch)
2015-03-16 19:05 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2015-03-16 19:40 PDT, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-03-16 18:57:17 PDT
Generalize the Document code that maintains a set of nodes with event handlers
Comment 1 Simon Fraser (smfr) 2015-03-16 19:05:21 PDT
Created attachment 248779 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-03-16 19:40:29 PDT
Created attachment 248783 [details]
Patch
Comment 3 Darin Adler 2015-03-16 20:21:39 PDT
Comment on attachment 248783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248783&action=review

> Source/WebCore/testing/Internals.cpp:1216
> -    const TouchEventTargetSet* touchHandlers = document->touchEventTargets();
> +    const EventTargetSet* touchHandlers = document->touchEventTargets();

I think auto is better for things like this.

> Source/WebCore/testing/Internals.cpp:1222
> -    for (TouchEventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter)
> +    for (EventTargetSet::const_iterator iter = touchHandlers->begin(); iter != touchHandlers->end(); ++iter)
>          count += iter->value;

This should be a modern for loop:

    for (auto& handler : *touchHandlers)
        count += handler.value;
Comment 4 Simon Fraser (smfr) 2015-03-16 21:45:00 PDT
https://trac.webkit.org/r181615