Bug 142744 - Expose WK2 preference for Animation Triggers runtime flag
Summary: Expose WK2 preference for Animation Triggers runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-16 13:48 PDT by Dean Jackson
Modified: 2015-03-16 17:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2015-03-16 14:19 PDT, Dean Jackson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-16 13:48:45 PDT 
We need a WK2 preference for the runtime flag.
Comment 1 Radar WebKit Bug Importer 2015-03-16 13:49:50 PDT 
<rdar://problem/20178288>
Comment 2 Dean Jackson 2015-03-16 14:19:15 PDT 
Created attachment 248748 [details]
Patch
Comment 3 Dean Jackson 2015-03-16 14:26:18 PDT 
Committed r181578: <http://trac.webkit.org/changeset/181578>
Comment 4 Csaba Osztrogonác 2015-03-16 15:45:17 PDT 
Comment on attachment 248748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248748&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:620
> +void InjectedBundle::setCSSAnimationTriggersEnabled(bool enabled)
> +{
> +#if ENABLE(CSS_REGIONS)
> +    RuntimeEnabledFeatures::sharedFeatures().setAnimationTriggersEnabled(enabled);
> +#else
> +    UNUSED_PARAM(enabled);
> +#endif
> +}

CSS_REGIONS ??? This is so ugly typo. That's why it broke the EFL and GTK builds.
I know you are allowed to do it ... but I can't understand why was it needed ...
Comment 5 Csaba Osztrogonác 2015-03-16 15:46:58 PDT 
Typo fix landed in http://trac.webkit.org/changeset/181582
Comment 6 Csaba Osztrogonác 2015-03-16 15:48:54 PDT 
One more fix landed in http://trac.webkit.org/changeset/181584
Comment 7 Dean Jackson 2015-03-16 17:11:52 PDT 
Thanks Ossy, and apologies.