Bug 142740 - Remove setCachedImage from HTMLImageElement since it is not used
Summary: Remove setCachedImage from HTMLImageElement since it is not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-16 11:41 PDT by Yoav Weiss
Modified: 2015-03-16 16:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2015-03-16 11:43 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2015-03-16 15:29 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2015-03-16 11:41:27 PDT 
Remove setCachedImage from HTMLImageElement since it is not used
Comment 1 Yoav Weiss 2015-03-16 11:43:37 PDT 
Created attachment 248737 [details]
Patch
Comment 2 Yoav Weiss 2015-03-16 11:51:24 PDT 
While working on https://bugs.webkit.org/show_bug.cgi?id=142694 I realized setCachedImage is just dead code, so I thought removing it as a separate patch would be best.
Comment 3 Chris Dumez 2015-03-16 11:56:18 PDT 
Comment on attachment 248737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248737&action=review

r=me % nit.

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

Nit: This is supposed to be between the bug URL and the changeling description.
Comment 4 Yoav Weiss 2015-03-16 15:29:05 PDT 
Created attachment 248754 [details]
Patch
Comment 5 WebKit Commit Bot 2015-03-16 16:13:30 PDT 
Comment on attachment 248754 [details]
Patch

Clearing flags on attachment: 248754

Committed r181591: <http://trac.webkit.org/changeset/181591>
Comment 6 WebKit Commit Bot 2015-03-16 16:13:35 PDT 
All reviewed patches have been landed.  Closing bug.