WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
142735
Style Check: runtime/enum_bitfields should allow "bool" values
https://bugs.webkit.org/show_bug.cgi?id=142735
Summary
Style Check: runtime/enum_bitfields should allow "bool" values
Dean Jackson
Reported
2015-03-16 10:53:37 PDT
A declaration like this: bool m_foo : 1; Produces a warning: ERROR: Source/WebCore/platform/animation/Animation.h:202: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] The source code talks about VS8, which is very very old. Also, it seems many people were ignoring this rule anyway.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2015-03-16 10:56:35 PDT
This warning is no longer relevant. Visual Studio 2013 (our only supported Windows compiler) and newer all support this syntax. This warning should be removed!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug