Bug 142735 - Style Check: runtime/enum_bitfields should allow "bool" values
Summary: Style Check: runtime/enum_bitfields should allow "bool" values
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-16 10:53 PDT by Dean Jackson
Modified: 2016-03-22 10:35 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-16 10:53:37 PDT 
A declaration like this:

bool m_foo : 1;

Produces a warning:
ERROR: Source/WebCore/platform/animation/Animation.h:202:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]

The source code talks about VS8, which is very very old. Also, it seems many people were ignoring this rule anyway.
Comment 1 Brent Fulgham 2015-03-16 10:56:35 PDT 
This warning is no longer relevant. Visual Studio 2013 (our only supported Windows compiler) and newer all support this syntax.

This warning should be removed!