Bug 142729 – W3C test parser and converter should use test importer host

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

When instantiated by the test importer, test parser and converter should use the same host. This would enable more test importer unit tests.

[youenn fablet]

Created attachment 248732 [details]
Patch

[Bem Jones-Bey]

Comment on attachment 248732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248732&action=review

> Tools/ChangeLog:7
> +

Can you add a summary of this change here? Something like the comment you have on the bug itself.

> Tools/ChangeLog:11
> +        * Scripts/webkitpy/w3c/test_converter.py:
> +        (_W3CTestConverter.handle_pi): Fixes style issue.

Why do you have a style issue in this file if you haven't changed anything else in it? I think you may be bundling too many small unrelated changes into this patch.

> Tools/ChangeLog:14
> +        * Scripts/webkitpy/w3c/test_downloader.py:
> +        (TestDownloader.git): Refactoring for future reuse.
> +        (TestDownloader.checkout_test_repository): Making use of the new git function.

You should do this refactoring in the change that needs it.

> Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:39
>  from webkitpy.w3c.test_importer import TestImporter
> +from webkitpy.w3c.test_importer import parse_args

I believe you can combine these two lines into one.

> Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:50
> +

Remove this extra line.

[youenn fablet]

Created attachment 248846 [details]
Fixing change log and cleaning style issues

[Bem Jones-Bey]

Comment on attachment 248846 [details]
Fixing change log and cleaning style issues

r=me

[WebKit Commit Bot]

Comment on attachment 248846 [details]
Fixing change log and cleaning style issues

Clearing flags on attachment: 248846

Committed r181661: <http://trac.webkit.org/changeset/181661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.