Bug 142716 - Make DatabaseContext suspendable if there is no pending database activity
Summary: Make DatabaseContext suspendable if there is no pending database activity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-15 17:49 PDT by Chris Dumez
Modified: 2015-03-17 10:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.85 KB, patch)
2015-03-15 17:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-03-15 17:49:08 PDT 
Make DatabaseContext suspendable if there is no pending database activity, i.e.
- Pending Database creation JS callback
- Pending transaction(s)

Suspending is safe in this case because we are not going to interrupt any database activity, nor fire any JS event.

This will greatly increase the likelihood of pages using websql to enter the PageCache.

Radar: <rdar://problem/19923085>
Comment 1 Chris Dumez 2015-03-15 17:54:21 PDT 
Created attachment 248694 [details]
Patch
Comment 2 Andreas Kling 2015-03-16 12:34:40 PDT 
Comment on attachment 248694 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-03-16 13:21:01 PDT 
Comment on attachment 248694 [details]
Patch

Clearing flags on attachment: 248694

Committed r181577: <http://trac.webkit.org/changeset/181577>
Comment 4 WebKit Commit Bot 2015-03-16 13:21:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2015-03-17 10:52:07 PDT 
This broke Windows tests because Windows does not support this feature.

Added Skip declarations in r181652 <https://trac.webkit.org/changeset/181652>