Bug 142715 - CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
Summary: CSS: fix the case-insensitive matching of the attribute selectors Begin, End ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-15 17:42 PDT by Benjamin Poulain
Modified: 2015-03-15 23:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (161.72 KB, patch)
2015-03-15 17:51 PDT, Benjamin Poulain 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-03-15 17:42:18 PDT 
CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
Comment 1 Benjamin Poulain 2015-03-15 17:51:20 PDT 
Created attachment 248693 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-15 17:54:06 PDT 
Attachment 248693 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/StringCommon.h:208:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:215:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/text/StringCommon.h:247:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2015-03-15 22:54:14 PDT 
Comment on attachment 248693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248693&action=review

r=me.

> Source/WTF/ChangeLog:20
> +        I moved the low level equal() code form StringImpl to StringCommon

... code FROM StringImple ...
Comment 4 Benjamin Poulain 2015-03-15 23:52:16 PDT 
Committed r181525: <http://trac.webkit.org/changeset/181525>