Bug 142686 - Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation
Summary: Object allocation sinking phase shouldn't re-decorate previously sunken alloc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 141174
  Show dependency tree / graph
 
Reported: 2015-03-13 18:37 PDT by Filip Pizlo
Modified: 2015-03-13 19:51 PDT (History)
11 users (show)

See Also:

Attachments
the patch (3.19 KB, patch)
2015-03-13 18:39 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-13 18:37:42 PDT 
When you run the elidable-new-object-roflcopter test, you'll see that there are many repeated PutStructureHints and PutByOffsetHints.  These are because we handle already-sunken allocations from previous fixpoint iterations inside the code for handling those allocations we are sinking on *this* fixpoint iteration.  This is a mostly benign bug; its main effect is that if the phase does many fixpoint iterations then you'll get a lot of duplicated code.
Comment 1 Filip Pizlo 2015-03-13 18:39:21 PDT 
Created attachment 248631 [details]
the patch
Comment 2 Filip Pizlo 2015-03-13 19:51:36 PDT 
Landed in http://trac.webkit.org/changeset/181495