progress
Created attachment 248618 [details] Patch
Created attachment 248619 [details] Patch
Comment on attachment 248619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248619&action=review LGTM as in-progress patch to use CMake for Mac and Win ports. > CMakeLists.txt:30 > + set(WebKit_LIBRARY_TYPE SHARED) LIBRARY_TYPE is defined in 135 ~ 136 lines. It would be define it there. 135: set(WebKit2_LIBRARY_TYPE SHARED) 136: set(WebCoreTestSupport_LIBRARY_TYPE STATIC) > Source/WebCore/PlatformMac.cmake:26 > + "${WEBCORE_DIR}/platform/spi/cf" nit: Looks like wrong alphabet order.
Created attachment 248628 [details] Patch
I want cake!
http://trac.webkit.org/changeset/181496 Geoff, go get some cake! CMake works with jsc on Mac now.