Bug 142680 - progress towards cake on mac
Summary: progress towards cake on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-13 15:52 PDT by Alex Christensen
Modified: 2015-03-13 19:59 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.69 KB, patch)
2015-03-13 16:25 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (9.79 KB, patch)
2015-03-13 16:37 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.95 KB, patch)
2015-03-13 18:09 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-03-13 15:52:49 PDT
progress
Comment 1 Alex Christensen 2015-03-13 16:25:47 PDT
Created attachment 248618 [details]
Patch
Comment 2 Alex Christensen 2015-03-13 16:37:18 PDT
Created attachment 248619 [details]
Patch
Comment 3 Gyuyoung Kim 2015-03-13 17:38:40 PDT
Comment on attachment 248619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248619&action=review

LGTM as in-progress patch to use CMake for Mac and Win ports.

> CMakeLists.txt:30
> +    set(WebKit_LIBRARY_TYPE SHARED)

LIBRARY_TYPE is defined in 135 ~ 136 lines. It would be define it there.

135: set(WebKit2_LIBRARY_TYPE SHARED)
136: set(WebCoreTestSupport_LIBRARY_TYPE STATIC)

> Source/WebCore/PlatformMac.cmake:26
> +    "${WEBCORE_DIR}/platform/spi/cf"

nit: Looks like wrong alphabet order.
Comment 4 Alex Christensen 2015-03-13 18:09:18 PDT
Created attachment 248628 [details]
Patch
Comment 5 Geoffrey Garen 2015-03-13 18:15:46 PDT
I want cake!
Comment 6 Alex Christensen 2015-03-13 19:59:57 PDT
http://trac.webkit.org/changeset/181496

Geoff, go get some cake!  CMake works with jsc on Mac now.