Bug 142677 – Stop image from displaying when src attribute is removed or emptied

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Stop image from displaying when src attribute is removed or emptied

[Yoav Weiss]

Created attachment 248601 [details]
Patch

[Yoav Weiss]

Created attachment 248602 [details]
Patch

[Chris Dumez]

Comment on attachment 248602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248602&action=review

r=me % nits.

> Source/WebCore/loader/ImageLoader.cpp:174
> +    if (!attr.isNull() && attr == m_failedLoadURL)

I would have a slight preference for if (!m_failedLoadURL.isEmpty() && m_failedLoadURL == attr), with a comment saying something like "Do not to reload an URL we already failed to load".

> LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

[Yoav Weiss]

Created attachment 248605 [details]
Patch

[Chris Dumez]

Hmm, these tests may be failing on EWS:
canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html [ Failure ]
canvas/philip/tests/2d.pattern.image.incomplete.omitted.html [ Failure ]

PTAL.

[Build Bot]

Comment on attachment 248605 [details]
Patch

Attachment 248605 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6063795008962560

New failing tests:
canvas/philip/tests/2d.pattern.image.incomplete.omitted.html
canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html

[Build Bot]

Created attachment 248607 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

(In reply to comment #5)
> Hmm, these tests may be failing on EWS:
> canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html [ Failure ]
> canvas/philip/tests/2d.pattern.image.incomplete.omitted.html [ Failure ]
> 
> PTAL.

According to https://www.w3.org/Bugs/Public/show_bug.cgi?id=13768:
2d.drawImage.image.incomplete.empty.html
2d.drawImage.image.incomplete.omitted.html
2d.drawImage.incomplete.html

have been replaced with

2d.drawImage.incomplete.emptysrc.html
2d.drawImage.incomplete.immediate.html
2d.drawImage.incomplete.nosrc.html
2d.drawImage.incomplete.reload.html
2d.drawImage.incomplete.removedsrc.html

and

2d.pattern.image.incomplete.empty.html
2d.pattern.image.incomplete.html
2d.pattern.image.incomplete.omitted.html

with

2d.pattern.image.broken.html
2d.pattern.image.incomplete.emptysrc.html
2d.pattern.image.incomplete.immediate.html
2d.pattern.image.incomplete.nosrc.html
2d.pattern.image.incomplete.reload.html
2d.pattern.image.incomplete.removedsrc.html

[Chris Dumez]

(In reply to comment #8)
> (In reply to comment #5)
> > Hmm, these tests may be failing on EWS:
> > canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html [ Failure ]
> > canvas/philip/tests/2d.pattern.image.incomplete.omitted.html [ Failure ]
> > 
> > PTAL.
> 
> According to https://www.w3.org/Bugs/Public/show_bug.cgi?id=13768:
> 2d.drawImage.image.incomplete.empty.html
> 2d.drawImage.image.incomplete.omitted.html
> 2d.drawImage.incomplete.html
> 
> have been replaced with
> 
> 2d.drawImage.incomplete.emptysrc.html
> 2d.drawImage.incomplete.immediate.html
> 2d.drawImage.incomplete.nosrc.html
> 2d.drawImage.incomplete.reload.html
> 2d.drawImage.incomplete.removedsrc.html
> 
> and
> 
> 2d.pattern.image.incomplete.empty.html
> 2d.pattern.image.incomplete.html
> 2d.pattern.image.incomplete.omitted.html
> 
> with
> 
> 2d.pattern.image.broken.html
> 2d.pattern.image.incomplete.emptysrc.html
> 2d.pattern.image.incomplete.immediate.html
> 2d.pattern.image.incomplete.nosrc.html
> 2d.pattern.image.incomplete.reload.html
> 2d.pattern.image.incomplete.removedsrc.html

We may want to import the new ones from https://github.com/w3c/web-platform-tests/tree/master/2dcontext/fill-and-stroke-styles and remove the ones that were dropped.

[Build Bot]

Comment on attachment 248605 [details]
Patch

Attachment 248605 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5297795644784640

New failing tests:
canvas/philip/tests/2d.pattern.image.incomplete.omitted.html
canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html

[Build Bot]

Created attachment 248608 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Yoav Weiss]

Created attachment 249320 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 249320 [details]
Patch

Clearing flags on attachment: 249320

Committed r181897: <http://trac.webkit.org/changeset/181897>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.