Bug 142662 – Elements with backdrop-filter cannot be clipped with clip-path or mask

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Jer Noble]

Elements with a backdrop-filter cannot be clipped with border-radius, clip-path, clip, or mask.

[Jer Noble]

Created attachment 248578 [details]
backdrop-blur-clip-path testcase

[Radar WebKit Bug Importer]

<rdar://problem/20150192>

[Antoine Quint]

Created attachment 279233 [details]
Patch

[Build Bot]

Comment on attachment 279233 [details]
Patch

Attachment 279233 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1342414

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279234 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279233 [details]
Patch

Attachment 279233 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1342413

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279235 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279233 [details]
Patch

Attachment 279233 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1342486

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279236 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 279239 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 279239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279239&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2456
> +    hostLayerForSublayers()->setMask(maskCALayer);

I think using primaryLayer() would be more appropriate.

You also need to fix the code below to do the right thing for layer clones (test with -webkit-box-reflect on something with a backdrop; uknown if this works now).

[Dean Jackson]

Comment on attachment 279239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279239&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2456
>> +    hostLayerForSublayers()->setMask(maskCALayer);
> 
> I think using primaryLayer() would be more appropriate.
> 
> You also need to fix the code below to do the right thing for layer clones (test with -webkit-box-reflect on something with a backdrop; uknown if this works now).

I'm not sure it works.

[Antoine Quint]

(In reply to comment #12)
> Comment on attachment 279239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279239&action=review
> 
> >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2456
> >> +    hostLayerForSublayers()->setMask(maskCALayer);
> > 
> > I think using primaryLayer() would be more appropriate.
> > 
> > You also need to fix the code below to do the right thing for layer clones (test with -webkit-box-reflect on something with a backdrop; uknown if this works now).
> 
> I'm not sure it works.

It doesn't work, before or after this patch. No reflections are drawn when a clip-path is applied. I think this falls outside the scope of this particular bug.

[Antoine Quint]

Created attachment 279647 [details]
Patch

[Antoine Quint]

Created attachment 279649 [details]
Patch

[Build Bot]

Comment on attachment 279649 [details]
Patch

Attachment 279649 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1374690

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279650 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279649 [details]
Patch

Attachment 279649 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1374688

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279651 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279649 [details]
Patch

Attachment 279649 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1374765

New failing tests:
css3/filters/backdrop/backdrop-filter-with-clip-path.html

[Build Bot]

Created attachment 279652 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 279682 [details]
Patch

[Antoine Quint]

Created attachment 279691 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 279691 [details]
Patch for landing

Rejecting attachment 279691 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/1376363

[WebKit Commit Bot]

Created attachment 279695 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[WebKit Commit Bot]

Comment on attachment 279691 [details]
Patch for landing

Clearing flags on attachment: 279691

Committed r201349: <http://trac.webkit.org/changeset/201349>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r201349 for reason:

This change caused compositing tests to assert on iOS simulator

Committed r201357: <http://trac.webkit.org/changeset/201357>

[Ryan Haddad]

(In reply to comment #28)
> Reverted r201349 for reason:
> 
> This change caused compositing tests to assert on iOS simulator
> 
> Committed r201357: <http://trac.webkit.org/changeset/201357>

<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Debug%20WK2%20%28Tests%29/builds/2138>

[Antoine Quint]

Created attachment 279747 [details]
Patch

[Antoine Quint]

Created attachment 279750 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 279750 [details]
Patch for landing

Clearing flags on attachment: 279750

Committed r201374: <http://trac.webkit.org/changeset/201374>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.