Bug 142650 – border-image with 'fill' keyword does not fill the middle area unless the border width is greater than zero

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Said Abou-Hallawa]

Created attachment 248566 [details]
Test case

Setting the border width should have an affect on drawing the middle area. The middle area should be drawn regardless border width is greater than zero or not. The border width and style should only affect the border around the middle area.

[Said Abou-Hallawa]

Created attachment 248567 [details]
Patch

[Said Abou-Hallawa]

Created attachment 248587 [details]
Patch

[Said Abou-Hallawa]

Created attachment 249338 [details]
Patch

[Said Abou-Hallawa]

I found out the InlineFlowBox does not draw the middle area unless the border width is greater than zero. I added a new function in RenderStyle and I called it hasBorderDecoration(). It will return true if the border width is greater than zero or the border-image has the keyword 'fill'. This function is going to be used to control whether we need to draw the border decoration for RenderBox, RenderTable and InlineFlowBox or not. I also added a new test specific to InlineFlowBox.

[Radar WebKit Bug Importer]

<rdar://problem/20279686>

[Simon Fraser (smfr)]

Comment on attachment 249338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249338&action=review

> Source/WebCore/ChangeLog:10
> +        border-image with 'fill' keyword does not fill the middle area unless the border width is greater than zero.
> +        https://bugs.webkit.org/show_bug.cgi?id=142650.
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        The decoration of a RenderBox, a RenderTable or an InlineFlowBox should be
> +        drawn if its RenderStyle has a non-zero width border or the border-image
> +        has the keyword fill.

The test cases all use SVG images, but there's no mention of SVG in the changelog here. Can you clarify?

[Said Abou-Hallawa]

(In reply to comment #6)
> Comment on attachment 249338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249338&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        border-image with 'fill' keyword does not fill the middle area unless the border width is greater than zero.
> > +        https://bugs.webkit.org/show_bug.cgi?id=142650.
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        The decoration of a RenderBox, a RenderTable or an InlineFlowBox should be
> > +        drawn if its RenderStyle has a non-zero width border or the border-image
> > +        has the keyword fill.
> 
> The test cases all use SVG images, but there's no mention of SVG in the
> changelog here. Can you clarify?

The bug is not specific to SVG. It is reproducible for any kind of images. An SVG image with intrinsic size is almost the same as a bitmap image. Because the SVG size is smaller than the size of the bitmap image and because its drawing can be easily deduced from the markup, I'd rather include an SVG in my tests if possible and if the bug is not specific to bitmap images.

[WebKit Commit Bot]

Comment on attachment 249338 [details]
Patch

Clearing flags on attachment: 249338

Committed r182197: <http://trac.webkit.org/changeset/182197>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.