Bug 142645 - Disable Yarr JIT for ARMv7k
Summary: Disable Yarr JIT for ARMv7k
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 15:19 PDT by Michael Saboff
Modified: 2015-03-19 14:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2015-03-12 16:33 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-03-12 15:19:57 PDT
The Yarr JIT should be disabled for ARMv7k just like the JavaScript JITs.
Comment 1 Michael Saboff 2015-03-12 16:33:59 PDT
Created attachment 248553 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-12 17:41:17 PDT
Comment on attachment 248553 [details]
Patch

Clearing flags on attachment: 248553

Committed r181462: <http://trac.webkit.org/changeset/181462>
Comment 3 WebKit Commit Bot 2015-03-12 17:41:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Geoffrey Garen 2015-03-12 19:35:20 PDT
Comment on attachment 248553 [details]
Patch

We believe that ARMv7k is not significantly different from ARMv7. What difference accounts for the YARR JIT being broken?
Comment 5 Geoffrey Garen 2015-03-12 19:37:23 PDT
Comment on attachment 248553 [details]
Patch

Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that explicitly:

#if !defined(ENABLE_YARR_JIT) && ENABLE(JIT)
#define ENABLE_YARR_JIT 1
#endif
Comment 6 Michael Saboff 2015-03-14 08:44:03 PDT
(In reply to comment #5)
> Comment on attachment 248553 [details]
> Patch
> 
> Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that
> explicitly:
> 
> #if !defined(ENABLE_YARR_JIT) && ENABLE(JIT)
> #define ENABLE_YARR_JIT 1
> #endif

I'll make this change.
Comment 7 Michael Saboff 2015-03-19 14:15:04 PDT
Update committed r181501: <http://trac.webkit.org/changeset/181501>