WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142645
Disable Yarr JIT for ARMv7k
https://bugs.webkit.org/show_bug.cgi?id=142645
Summary
Disable Yarr JIT for ARMv7k
Michael Saboff
Reported
2015-03-12 15:19:57 PDT
The Yarr JIT should be disabled for ARMv7k just like the JavaScript JITs.
Attachments
Patch
(1.55 KB, patch)
2015-03-12 16:33 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2015-03-12 16:33:59 PDT
Created
attachment 248553
[details]
Patch
WebKit Commit Bot
Comment 2
2015-03-12 17:41:17 PDT
Comment on
attachment 248553
[details]
Patch Clearing flags on attachment: 248553 Committed
r181462
: <
http://trac.webkit.org/changeset/181462
>
WebKit Commit Bot
Comment 3
2015-03-12 17:41:21 PDT
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 4
2015-03-12 19:35:20 PDT
Comment on
attachment 248553
[details]
Patch We believe that ARMv7k is not significantly different from ARMv7. What difference accounts for the YARR JIT being broken?
Geoffrey Garen
Comment 5
2015-03-12 19:37:23 PDT
Comment on
attachment 248553
[details]
Patch Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that explicitly: #if !defined(ENABLE_YARR_JIT) && ENABLE(JIT) #define ENABLE_YARR_JIT 1 #endif
Michael Saboff
Comment 6
2015-03-14 08:44:03 PDT
(In reply to
comment #5
)
> Comment on
attachment 248553
[details]
> Patch > > Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that > explicitly: > > #if !defined(ENABLE_YARR_JIT) && ENABLE(JIT) > #define ENABLE_YARR_JIT 1 > #endif
I'll make this change.
Michael Saboff
Comment 7
2015-03-19 14:15:04 PDT
Update committed
r181501
: <
http://trac.webkit.org/changeset/181501
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug