Bug 142638 - Prohibit GC while sweeping
Summary: Prohibit GC while sweeping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 13:26 PDT by Geoffrey Garen
Modified: 2015-03-13 13:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2015-03-12 13:36 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2015-03-12 13:50 PDT, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-03-12 13:26:55 PDT 
Prohibit GC while sweeping
Comment 1 Geoffrey Garen 2015-03-12 13:36:39 PDT 
Created attachment 248538 [details]
Patch
Comment 2 Geoffrey Garen 2015-03-12 13:50:53 PDT 
Created attachment 248540 [details]
Patch
Comment 3 Andreas Kling 2015-03-12 15:59:35 PDT 
Comment on attachment 248540 [details]
Patch

This seems entirely reasonable. r=me
Comment 4 Filip Pizlo 2015-03-12 16:02:51 PDT 
Comment on attachment 248540 [details]
Patch

I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then we won't GC as we're popping the DeferGC scope.  I believe in such cases it's always preferable to wait until the allocation itself realizes that it should GC.
Comment 5 Geoffrey Garen 2015-03-12 19:39:51 PDT 
(In reply to comment #4)
> Comment on attachment 248540 [details]
> Patch
> 
> I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then
> we won't GC as we're popping the DeferGC scope.  I believe in such cases
> it's always preferable to wait until the allocation itself realizes that it
> should GC.

OK. Will do.
Comment 6 Geoffrey Garen 2015-03-13 13:15:08 PDT 
Committed r181486: <http://trac.webkit.org/changeset/181486>