Bug 142637 - ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
Summary: ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 13:11 PDT by Alexey Proskuryakov
Modified: 2015-03-16 16:59 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (1.65 KB, patch)
2015-03-16 16:11 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-03-12 13:11:59 PDT 
I get an assertion when running this test locally, always reproducible by repeating it multiple times:

run-webkit-tests plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html --repeat 100

The reason is that the QuickTime plug-in is 32-bit, so it fails to initialize, PluginView::didFailToInitializePlugin() sets m_plugin to 0, but then we start m_pluginSnapshotTimer regardless.

This makes me confused about how this test (or other snapshotting tests) can ever pass on any debug local builds. They all expect a snapshot that shouldn't be possible to make. 

See also rdar://problem/18994117, rdar://problem/16097212.
Comment 1 Alexey Proskuryakov 2015-03-16 16:11:23 PDT 
Created attachment 248764 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-03-16 16:59:04 PDT 
Comment on attachment 248764 [details]
proposed fix

Clearing flags on attachment: 248764

Committed r181599: <http://trac.webkit.org/changeset/181599>
Comment 3 WebKit Commit Bot 2015-03-16 16:59:08 PDT 
All reviewed patches have been landed.  Closing bug.