RESOLVED FIXED 142637
ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html 
https://bugs.webkit.org/show_bug.cgi?id=142637
Summary ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by...
Alexey Proskuryakov
Reported 2015-03-12 13:11:59 PDT
I get an assertion when running this test locally, always reproducible by repeating it multiple times: run-webkit-tests plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html --repeat 100 The reason is that the QuickTime plug-in is 32-bit, so it fails to initialize, PluginView::didFailToInitializePlugin() sets m_plugin to 0, but then we start m_pluginSnapshotTimer regardless. This makes me confused about how this test (or other snapshotting tests) can ever pass on any debug local builds. They all expect a snapshot that shouldn't be possible to make. See also rdar://problem/18994117, rdar://problem/16097212.
Attachments
proposed fix (1.65 KB, patch)
2015-03-16 16:11 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-03-16 16:11:23 PDT
Created attachment 248764 [details] proposed fix
WebKit Commit Bot
Comment 2 2015-03-16 16:59:04 PDT
Comment on attachment 248764 [details] proposed fix Clearing flags on attachment: 248764 Committed r181599: <http://trac.webkit.org/changeset/181599>
WebKit Commit Bot
Comment 3 2015-03-16 16:59:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.