WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
142634
Sink the Vector<uint8_t> buffer into the SerializedScriptValue constructor
https://bugs.webkit.org/show_bug.cgi?id=142634
Summary
Sink the Vector<uint8_t> buffer into the SerializedScriptValue constructor
Zan Dobersek
Reported
2015-03-12 12:56:12 PDT
Sink the Vector<uint8_t> buffer into the SerializedScriptValue constructor
Attachments
Patch
(15.29 KB, patch)
2015-03-12 13:29 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(15.51 KB, patch)
2015-03-17 03:22 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(17.72 KB, patch)
2015-03-17 13:37 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(19.10 KB, patch)
2016-01-03 03:36 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch for landing
(19.17 KB, patch)
2016-01-18 10:40 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2015-03-12 13:29:29 PDT
Created
attachment 248537
[details]
Patch
Darin Adler
Comment 2
2015-03-12 18:18:06 PDT
Comment on
attachment 248537
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=248537&action=review
> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:322 > +Deprecated::ScriptValue deserializeIDBValueBuffer(JSC::ExecState* exec, Vector<uint8_t>&& buffer, bool keyIsDefined)
Need to update the declaration in the IDBBindingUtilities.h header file too. Or delete that declaration entirely and mark this static so it has internal linkage.
Zan Dobersek
Comment 3
2015-03-17 03:22:23 PDT
Created
attachment 248840
[details]
Patch
Zan Dobersek
Comment 4
2015-03-17 13:37:40 PDT
Created
attachment 248865
[details]
Patch
Zan Dobersek
Comment 5
2016-01-03 03:36:23 PST
Created
attachment 268135
[details]
Patch
Michael Catanzaro
Comment 6
2016-01-03 18:03:08 PST
Comment on
attachment 268135
[details]
Patch Looks like a nice cleanup. This needs approved by an owner, though.
Darin Adler
Comment 7
2016-01-15 16:47:04 PST
Comment on
attachment 268135
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=268135&action=review
> Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp:182 > + RefPtr<WebCore::SerializedScriptValue> value = WebCore::SerializedScriptValue::adopt(dataReference.vector()); > > handler->client().didPostMessage(*page, *frame, securityOrigin, *value);
I think this reads better without a local variable: handler->client().didPostMessage(*page, *frame, securityOrigin, *WebCore::SerializedScriptValue::adopt(dataReference.vector()));
> Source/WebKit2/UIProcess/WebPageProxy.cpp:4701 > + RefPtr<API::SerializedScriptValue> returnValue = API::SerializedScriptValue::adopt(WTFMove(data)); > + callback->performCallbackWithReturnValue(returnValue.get(), hadException, details);
i think this still reads better without a local variable: callback->performCallbackWithReturnValue(API::SerializedScriptValue::adopt(WTFMove(data)).get(), hadException, details);
Zan Dobersek
Comment 8
2016-01-18 10:40:15 PST
Created
attachment 269231
[details]
Patch for landing Addressed the recommendations in
comment #7
.
WebKit Commit Bot
Comment 9
2016-01-18 12:26:56 PST
Comment on
attachment 269231
[details]
Patch for landing Clearing flags on attachment: 269231 Committed
r195235
: <
http://trac.webkit.org/changeset/195235
>
WebKit Commit Bot
Comment 10
2016-01-18 12:27:00 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug