Bug 142633 - LLInt's inline cache should use StructureID instead of Structure*.
Summary: LLInt's inline cache should use StructureID instead of Structure*.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.10
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 12:11 PDT by Jiho Choi
Modified: 2017-04-24 19:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.47 KB, patch)
2015-03-13 09:26 PDT, Jiho Choi 		beidson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiho Choi 2015-03-12 12:11:08 PDT 
Initially discussed here:
https://lists.webkit.org/pipermail/webkit-dev/2015-March/027294.html

LLInt's inline cache seems to be left out when refactoring JSCell to have 32-bit StructureID. LLInt's inline cache is currently using Structure* even in 64-bit platforms where StructureID is uint32_t so that it requires an extra load to retrieve Structure*. Note that there is no such indirection in 32-bit platform where StructureID is typedef'ed as Structure*.
This patch is to change LLInt's inline cache to use StructureID, and it will mostly affect 64-bit platform and remove unnecessary loads in LLInt's inline cache.
Comment 1 Jiho Choi 2015-03-12 12:17:23 PDT 
Working on it.
Comment 2 Jiho Choi 2015-03-13 09:26:28 PDT 
Created attachment 248586 [details]
Patch
Comment 3 Brady Eidson 2017-04-24 19:05:44 PDT 
Comment on attachment 248586 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.